You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/05/31 04:36:41 UTC
Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER, DATABASE,
TABLE, URI] xxx
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/
-----------------------------------------------------------
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Bugs: SENTRY-215
https://issues.apache.org/jira/browse/SENTRY-215
Repository: sentry
Description
-------
Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
Diff: https://reviews.apache.org/r/22105/diff/
Testing
-------
Added new integration tests
Thanks,
Sravya Tirukkovalur
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On June 1, 2014, 11:10 p.m., Arun Suresh wrote:
> > It looks quite good..
> >
> > Maybe we should Probably add one more testcase where:
> > * db1 has 1 table t1
> > * user1 is given Db level grant
> > * SHOW GRANT on table should return positive
> >
Added more test cases including this one and other negative test cases. Thanks Arun!
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44471
-----------------------------------------------------------
On May 31, 2014, 2:36 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 2:36 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-215
> https://issues.apache.org/jira/browse/SENTRY-215
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
>
> Diff: https://reviews.apache.org/r/22105/diff/
>
>
> Testing
> -------
>
> Added new integration tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44471
-----------------------------------------------------------
It looks quite good..
Maybe we should Probably add one more testcase where:
* db1 has 1 table t1
* user1 is given Db level grant
* SHOW GRANT on table should return positive
- Arun Suresh
On May 31, 2014, 2:36 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 2:36 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-215
> https://issues.apache.org/jira/browse/SENTRY-215
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
>
> Diff: https://reviews.apache.org/r/22105/diff/
>
>
> Testing
> -------
>
> Added new integration tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44521
-----------------------------------------------------------
Ship it!
LGTM
- Prasad Mujumdar
On June 2, 2014, 6:09 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 6:09 p.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-215
> https://issues.apache.org/jira/browse/SENTRY-215
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
>
> Diff: https://reviews.apache.org/r/22105/diff/
>
>
> Testing
> -------
>
> Added new integration tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/
-----------------------------------------------------------
(Updated June 2, 2014, 6:09 p.m.)
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Changes
-------
Updated the patch with review comments. Also "grant all on server" privilege was being shown as empty value in database column, fixed it to instead show "*".
Bugs: SENTRY-215
https://issues.apache.org/jira/browse/SENTRY-215
Repository: sentry
Description
-------
Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
Diff: https://reviews.apache.org/r/22105/diff/
Testing
-------
Added new integration tests
Thanks,
Sravya Tirukkovalur
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On June 2, 2014, 4:54 p.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java, line 222
> > <https://reviews.apache.org/r/22105/diff/1/?file=600626#file600626line222>
> >
> > Are we removing this additional error checking ?
This error checking is handled in analyzePrivilegeObject().
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44506
-----------------------------------------------------------
On May 31, 2014, 2:36 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 2:36 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-215
> https://issues.apache.org/jira/browse/SENTRY-215
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
>
> Diff: https://reviews.apache.org/r/22105/diff/
>
>
> Testing
> -------
>
> Added new integration tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22105: SENTRY-215: SHOW GRANT ROLE xxx ON [SERVER,
DATABASE, TABLE, URI] xxx
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44506
-----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
<https://reviews.apache.org/r/22105/#comment78908>
Are we removing this additional error checking ?
- Prasad Mujumdar
On May 31, 2014, 2:36 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 2:36 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-215
> https://issues.apache.org/jira/browse/SENTRY-215
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 1012605e4d09074851704ecf9df4e4a613cd919d
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 6d890411e5968bd6dd7e3f489bdf08d9842547d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 50aadb868276f88ea6c36e23d83d118ca7205c44
>
> Diff: https://reviews.apache.org/r/22105/diff/
>
>
> Testing
> -------
>
> Added new integration tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>