You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "massakam (via GitHub)" <gi...@apache.org> on 2023/02/15 06:28:05 UTC
[GitHub] [pulsar-site] massakam opened a new pull request, #410: [improve][doc] Add description for using Copper Argos
massakam opened a new pull request, #410:
URL: https://github.com/apache/pulsar-site/pull/410
### Documentation
In https://github.com/apache/pulsar/pull/19445, I added some new parameters to the authentication plugin for Athenz, so I added a description about them.
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#issuecomment-1436238758
ping @nodece
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] massakam commented on a diff in pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "massakam (via GitHub)" <gi...@apache.org>.
massakam commented on code in PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#discussion_r1107948038
##########
docs/security-athenz.md:
##########
@@ -172,6 +177,45 @@ client, err := pulsarNewClient(ClientOptions{
</Tabs>
````
+### When using Copper Argos
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#issuecomment-1453115629
@nodece Can you pls review this PR from the technical perspective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] nodece commented on pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#issuecomment-1453214106
@momo-jun @Anonymitaet Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#discussion_r1107936378
##########
docs/security-athenz.md:
##########
@@ -172,6 +177,45 @@ client, err := pulsarNewClient(ClientOptions{
</Tabs>
````
+### When using Copper Argos
Review Comment:
```suggestion
### Use Copper Argos
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #410:
URL: https://github.com/apache/pulsar-site/pull/410#issuecomment-1431159784
@massakam thanks for adding the docs!
I pushed a commit to fix a display issue of code blocks, which I found when I was reviewing the content. No offence:) It's not related to your additions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun merged pull request #410: [improve][doc] Add description for using Copper Argos
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun merged PR #410:
URL: https://github.com/apache/pulsar-site/pull/410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org