You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by s1ck <gi...@git.apache.org> on 2016/03/14 00:09:06 UTC
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1786
[FLINK-3611] [docs] corrected link in CONTRIBUTING.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck/flink FLINK-3611
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1786
----
commit f79cbedcfd82de995cf0a8df6fe9fb3601e4f6d8
Author: Martin Junghanns <m....@mailbox.org>
Date: 2016-03-13T23:08:10Z
[FLINK-3611] [docs] corrected link in CONTRIBUTING.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-199717216
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-199704337
+1, Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-196093870
Hi @s1ck, thanks for opening pull request! I would like to change this link to "Contributing Code" (http://flink.apache.org/contribute-code.html) page rather than "Coding Guidelines". How about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-197206450
+1 for your suggestion @s1ck.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...
Posted by s1ck <gi...@git.apache.org>.
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-196175512
Sounds good, but then I would change the text to:
`A detailed explanation can be found in our [Contribute Code Guide](http://flink.apache.org/contribute-code.html) which also contains a list of coding guidelines that you should follow.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---