You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Cseh <ge...@cloudera.com> on 2017/06/01 11:53:40 UTC
Re: Review Request 59635: OOZIE-2923 Improve Spark options parsing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59635/#review176600
-----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java
Lines 137 (patched)
<https://reviews.apache.org/r/59635/#comment249971>
This code path is only active in yarn mode, please change the testDriverClassPathArgsParsing to test in yarn mode
- Peter Cseh
On May 31, 2017, 5:03 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59635/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 5:03 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2923 Improve Spark options parsing
>
>
> Diffs
> -----
>
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/HadoopUriFinder.java PRE-CREATION
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/JarFilter.java PRE-CREATION
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java PRE-CREATION
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java 68f7a607344ac8b3c11ab08220f27139433a998e
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java PRE-CREATION
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java 2d4c83c6ecff4be306c2864d1fb9650f1b58dcf2
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java PRE-CREATION
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java 5f6a0cdcde21287580f6b7037594669b508d24ef
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java 31f53acca24d1dd645e32a37b58643b7a0a3cacd
>
>
> Diff: https://reviews.apache.org/r/59635/diff/3/
>
>
> Testing
> -------
>
> Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and `TestSparkArgsBuilder` for test cases.
>
>
> Thanks,
>
> András Piros
>
>