You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/16 11:26:45 UTC
[GitHub] [spark] sarutak opened a new pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
sarutak opened a new pull request #32205:
URL: https://github.com/apache/spark/pull/32205
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR extends `ADD FILE/JAR/ARCHIVE` commands to be able to take multiple path arguments like Hive.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make those commands more useful.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. In the current implementation, those commands can take a path which contains whitespaces without enclose it by neither `'` nor `"` but after this change, users need to enclose such paths.
I've note this incompatibility in the migration guide.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822257597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822241267
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822534421
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822115591
@HyukjinKwon Thank you for letting me know. I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-827978225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42528/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822170377
**[Test build #137572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137572/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822512103
**[Test build #137596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137596/testReport)** for PR 32205 at commit [`9fe3eee`](https://github.com/apache/spark/commit/9fe3eee6ffe34ae85b4a28fd2ce8dd8e6039ad64).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822158205
**[Test build #137540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137540/testReport)** for PR 32205 at commit [`002eaed`](https://github.com/apache/spark/commit/002eaed8755af4902c382bf81e522ed1f6589b84).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class PandasOnSparkFrameMethods(object):`
* `class PandasOnSparkSeriesMethods(object):`
* `class PandasOnSparkPlotAccessor(PandasObject):`
* `class PandasOnSparkBarPlot(PandasBarPlot, TopNPlotBase):`
* `class PandasOnSparkBoxPlot(PandasBoxPlot, BoxPlotBase):`
* `class PandasOnSparkHistPlot(PandasHistPlot, HistogramPlotBase):`
* `class PandasOnSparkPiePlot(PandasPiePlot, TopNPlotBase):`
* `class PandasOnSparkAreaPlot(PandasAreaPlot, SampledPlotBase):`
* `class PandasOnSparkLinePlot(PandasLinePlot, SampledPlotBase):`
* `class PandasOnSparkBarhPlot(PandasBarhPlot, TopNPlotBase):`
* `class PandasOnSparkScatterPlot(PandasScatterPlot, TopNPlotBase):`
* `class PandasOnSparkKdePlot(PandasKdePlot, KdePlotBase):`
* `class PandasOnSparkUsageLogger(object):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-827944584
**[Test build #138009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138009/testReport)** for PR 32205 at commit [`c7175de`](https://github.com/apache/spark/commit/c7175de8fc51b481960a9c40682483fe281db062).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32205:
URL: https://github.com/apache/spark/pull/32205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821148165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821261658
**[Test build #137486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137486/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821143921
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821109559
**[Test build #755422826](https://github.com/sarutak/spark/actions/runs/755422826)** for PR 32205 at commit [`7cd0628`](https://github.com/sarutak/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822116473
**[Test build #137540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137540/testReport)** for PR 32205 at commit [`002eaed`](https://github.com/apache/spark/commit/002eaed8755af4902c382bf81e522ed1f6589b84).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-827944584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822165015
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137540/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-828094768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821921300
@sarutak would you mind rebasing your branch against the latest master branch in Apache Spark? there have been a couple of CI updates so it has to be synced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822298435
**[Test build #137596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137596/testReport)** for PR 32205 at commit [`9fe3eee`](https://github.com/apache/spark/commit/9fe3eee6ffe34ae85b4a28fd2ce8dd8e6039ad64).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822127267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822246325
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-828094768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822224127
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-828084195
**[Test build #138009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138009/testReport)** for PR 32205 at commit [`c7175de`](https://github.com/apache/spark/commit/c7175de8fc51b481960a9c40682483fe281db062).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821148165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822534421
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822131770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42113/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822224127
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821118403
**[Test build #137486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137486/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822170377
**[Test build #137572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137572/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821267167
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137486/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822116473
**[Test build #137540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137540/testReport)** for PR 32205 at commit [`002eaed`](https://github.com/apache/spark/commit/002eaed8755af4902c382bf81e522ed1f6589b84).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822257597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42132/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-827978225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42528/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821141773
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822165015
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137540/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822223713
**[Test build #137572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137572/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822298435
**[Test build #137596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137596/testReport)** for PR 32205 at commit [`9fe3eee`](https://github.com/apache/spark/commit/9fe3eee6ffe34ae85b4a28fd2ce8dd8e6039ad64).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-828939736
Merged to `master`. Thanks @HyukjinKwon for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-822131770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42113/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-821118403
**[Test build #137486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137486/testReport)** for PR 32205 at commit [`7cd0628`](https://github.com/apache/spark/commit/7cd0628268f4c09b146dc0f503ec8ae923fa01b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-825455084
@HyukjinKwon Do you have any comment on this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32205: [SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32205:
URL: https://github.com/apache/spark/pull/32205#issuecomment-828136494
@HyukjinKwon
> Just to clarify, these are all supported in Hive too, right? If that's the case, I think the change is fine
Yes. It works in Hive as documented (https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Commands).
I also confirmed with Hive 2.3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org