You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/28 03:13:59 UTC
[GitHub] [shardingsphere] MrCong233 opened a new pull request, #23130: ShardingSphere implements Global Logical Time feature.
MrCong233 opened a new pull request, #23130:
URL: https://github.com/apache/shardingsphere/pull/23130
…imeRule by yaml.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
ShardingSphere implements Global Logical Time feature.This is a openGauss + ShardingSphere feature implements distributed transaction fact-time consistency, and some of the code needs to be committed in ShardingSphere.
The basic process of this feature has been completed and the code is being refactored to meet the review requirements. I've now completed the Yaml parsing and GlobalRule initialization parts, and am refactoring the interface and implementation classes for GlobalLogicalTime.
《openGauss Global Logical Time Feature Design Specification》:
https://www.yuque.com/g/zhoucong-jjxdd/oz9b46/iqy7gdrv1bfd8322/collaborator/join?token=2wHlpJeS6MPCj7In
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ShardingSphere implements Global Logical Time feature. [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed pull request #23130: ShardingSphere implements Global Logical Time feature.
URL: https://github.com/apache/shardingsphere/pull/23130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23130: ShardingSphere implements Global Logical Time feature.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23130:
URL: https://github.com/apache/shardingsphere/pull/23130#issuecomment-1382723870
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23130](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf49862) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f6ad3b27f29e9e4c004322d2a6228fdbe52d7a4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6ad3b2) will **decrease** coverage by `0.12%`.
> The diff coverage is `19.20%`.
```diff
@@ Coverage Diff @@
## master #23130 +/- ##
============================================
- Coverage 49.75% 49.62% -0.13%
- Complexity 2510 2513 +3
============================================
Files 4110 4123 +13
Lines 58609 58859 +250
Branches 10134 10171 +37
============================================
+ Hits 29158 29211 +53
- Misses 26930 27123 +193
- Partials 2521 2525 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...text/transaction/TransactionConnectionContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb250ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQ29ubmVjdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ime/config/RedisConnectionOptionConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxsb2dpY2FsdGltZS9jb25maWcvUmVkaXNDb25uZWN0aW9uT3B0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ere/globallogicaltime/GlobalLogicalTimeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ2xvYmFsbG9naWNhbHRpbWUvR2xvYmFsTG9naWNhbFRpbWVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../globallogicaltime/rule/GlobalLogicalTimeRule.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ2xvYmFsbG9naWNhbHRpbWUvcnVsZS9HbG9iYWxMb2dpY2FsVGltZVJ1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...nector/GlobalLogicalTimeJedisPoolConfigParams.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dsb2JhbGxvZ2ljYWx0aW1lL3JlZGlzL2Nvbm5lY3Rvci9HbG9iYWxMb2dpY2FsVGltZUplZGlzUG9vbENvbmZpZ1BhcmFtcy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dis/connector/GlobalLogicalTimeRedisConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dsb2JhbGxvZ2ljYWx0aW1lL3JlZGlzL2Nvbm5lY3Rvci9HbG9iYWxMb2dpY2FsVGltZVJlZGlzQ29ubmVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../executor/BasedRedisGlobalLogicalTimeExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1sb2dpY2FsLXRpbWUvcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dsb2JhbGxvZ2ljYWx0aW1lL3JlZGlzL2V4ZWN1dG9yL0Jhc2VkUmVkaXNHbG9iYWxMb2dpY2FsVGltZUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `27.38% <0.00%> (-0.67%)` | :arrow_down: |
| [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `54.54% <0.00%> (-2.06%)` | :arrow_down: |
| [...kend/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcveWFtbC9ZYW1sUHJveHlTZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `55.55% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/23130?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #23130: ShardingSphere implements Global Logical Time feature.
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #23130:
URL: https://github.com/apache/shardingsphere/pull/23130#issuecomment-1367028855
Hi @MrCong233
The link <https://www.yuque.com/g/zhoucong-jjxdd/oz9b46/iqy7gdrv1bfd8322/collaborator/join?token=2wHlpJeS6MPCj7In> you provide cannot be accessed directly. Please describe your PR in a issue. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ShardingSphere implements Global Logical Time feature. [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #23130:
URL: https://github.com/apache/shardingsphere/pull/23130#issuecomment-1763900473
Since this pr has long time no reponse, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org