You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/01 00:23:14 UTC
[GitHub] [rocketmq-client-go] MaOreoreorui opened a new pull request #743: [ISSUE #744] check multiple topics in one batch
MaOreoreorui opened a new pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743
## What is the purpose of the change
issue #744
Because of the lack of pre-check, the message will be sent to the first topic when batch sending messages to multiple topics.
## Brief changelog
add check logic in func [ defaultProducer.checkMsg(msgs ...*primitive.Message) error ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on pull request #743: [ISSUE #744] check multiple topics in one batch
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743#issuecomment-981350764
Would you like to add a test for your pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] MaOreoreorui commented on pull request #743: [ISSUE #744] check multiple topics in one batch
Posted by GitBox <gi...@apache.org>.
MaOreoreorui commented on pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743#issuecomment-980843347
> @MaOreoreorui Good job! Could you create a related issue pls?
done 👨🏻💻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #743: check multiple topics in one batch
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743#issuecomment-980837607
@MaOreoreorui Good job! Could you create a related issue pls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling merged pull request #743: [ISSUE #744] check multiple topics in one batch
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] MaOreoreorui closed pull request #743: [ISSUE #744] check multiple topics in one batch
Posted by GitBox <gi...@apache.org>.
MaOreoreorui closed pull request #743:
URL: https://github.com/apache/rocketmq-client-go/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org