You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:04:45 UTC
[GitHub] [incubator-shardingsphere] JasonKing168 opened a new pull request
#4823: Fix #4785 check uniformed with all actual tables' meta data in once
when loading them
JasonKing168 opened a new pull request #4823: Fix #4785 check uniformed with all actual tables' meta data in once when loading them
URL: https://github.com/apache/incubator-shardingsphere/pull/4823
Fixes #4785.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #4823: Fix #4785 check uniformed with all actual tables' meta data
in once when loading them
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4823: Fix #4785 check uniformed with all actual tables' meta data in once when loading them
URL: https://github.com/apache/incubator-shardingsphere/pull/4823#discussion_r394196578
##########
File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java
##########
@@ -30,12 +30,8 @@
import javax.sql.DataSource;
import java.sql.SQLException;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
Review comment:
star import is not allowed.
you can use `mvn install` to check all code style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in
pull request #4823: Fix #4785 check uniformed with all actual tables' meta
data in once when loading them
Posted by GitBox <gi...@apache.org>.
JasonKing168 commented on a change in pull request #4823: Fix #4785 check uniformed with all actual tables' meta data in once when loading them
URL: https://github.com/apache/incubator-shardingsphere/pull/4823#discussion_r394203769
##########
File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java
##########
@@ -30,12 +30,8 @@
import javax.sql.DataSource;
import java.sql.SQLException;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
Review comment:
Ok, got it, thanks. I fix this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] JasonKing168 closed pull request #4823:
Fix #4785 check uniformed with all actual tables' meta data in once when
loading them
Posted by GitBox <gi...@apache.org>.
JasonKing168 closed pull request #4823: Fix #4785 check uniformed with all actual tables' meta data in once when loading them
URL: https://github.com/apache/incubator-shardingsphere/pull/4823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services