You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/08 01:20:09 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4494: build: Replace 'make download' with 'make flash', but keep both for now

gustavonihei commented on a change in pull request #4494:
URL: https://github.com/apache/incubator-nuttx/pull/4494#discussion_r703954708



##########
File path: tools/esp32/Config.mk
##########
@@ -147,12 +147,12 @@ endif
 
 ESPTOOL_BAUD ?= 921600
 
-# DOWNLOAD -- Download binary image via esptool.py
+# FLASHCMD -- Upload a binary image via esptool.py

Review comment:
       ````suggestion
   # FLASHCMD -- Download a binary image via esptool.py
   ```
   According to the Embedded Systems Dictionary, by Jack Ganssle, `download` is the defined convention for "moving data or code into a target's memory over a communications channel such as a serial port".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org