You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/02 03:06:56 UTC

[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1098: Add dotnet core 3.1 action support

mrutkows commented on a change in pull request #1098:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1098#discussion_r585214000



##########
File path: runtimes/runtimes.go
##########
@@ -480,6 +480,21 @@ var RUNTIME_DETAILS = []byte(`{
                     "attachmentName": "codefile",
                     "attachmentType": "text/plain"
                 }
+            },	    
+            {
+                "kind": "dotnet:3.1",

Review comment:
       Please add unit tests and perhaps an integration test to validate support in our CI/CD process. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org