You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ankon <gi...@git.apache.org> on 2016/05/31 15:45:23 UTC
[GitHub] cordova-android pull request: Cb 11343
GitHub user ankon opened a pull request:
https://github.com/apache/cordova-android/pull/308
Cb 11343
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ankon/cordova-android CB-11343
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #308
----
commit 765804226dd608a3e272b6f1010d0df24d535a82
Author: Andreas Kohn <an...@gmail.com>
Date: 2016-05-31T15:21:17Z
Fix a typo
commit 70ac31b4686a9eeee57311680e0230cdc51a356e
Author: Andreas Kohn <an...@gmail.com>
Date: 2016-05-31T15:30:17Z
Remove the check for javacPath
At this point this will always be false-y.
commit 8d2d21fd40018714436e961b7714df460837e6a2
Author: Andreas Kohn <an...@gmail.com>
Date: 2016-05-31T15:43:36Z
CB-11343: Handle Java versions after JEP-223
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223
Posted by ankon <gi...@git.apache.org>.
Github user ankon commented on the issue:
https://github.com/apache/cordova-android/pull/308
I'm not sure I follow here. In any case, what is needed to get this forward, and prepare the plugin for actually working with JDK 9?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/308
So, how do we test this one? Is this a Mac OS X or Linux issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11343: Handle Java versions after JEP-223
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/308
## [Current coverage][cc-pull] is **34.21%**
> Merging [#308][cc-pull] into [master][cc-base-branch] will not change coverage
```diff
@@ master #308 diff @@
==========================================
Files 11 11
Lines 947 947
Methods 194 194
Messages 0 0
Branches 153 153
==========================================
Hits 324 324
Misses 623 623
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d125ece...8573555][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/d125ece9e9598f6b4f52e2148e8005f0fbabc5c8...857355503635857d7bbe017a23566fa8db7eb42f
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/308?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #308: CB-11343: Handle Java versions after JEP-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223
Posted by ankon <gi...@git.apache.org>.
Github user ankon commented on the issue:
https://github.com/apache/cordova-android/pull/308
> So, how do we test this one? Is this a Mac OS X or Linux issue?
It's a "whereever you are able to run Java 9 (EA)"-issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/308
I couldn't even get Java 9 to work with Android when I installed it, even when it did pass the check, so for now I don't think I can accept this request right now. If you can try to update the Regex with the new branch, and show that you can actually compile Hello World using Java 9 Early Access, I might reconsider.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/308
Yeah, I'm amazed this fails, since I've been working on a different issue with this regex for a day finding out that check_reqs.js needs to be redone entirely because it just wants a result, literally any result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org