You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2025/10/09 06:22:32 UTC
[PR] [refactor](predicate) Refactor interface [doris]
Gabriel39 opened a new pull request, #56739:
URL: https://github.com/apache/doris/pull/56739
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384930083
<details>
<summary>ClickBench: <b>Total hot run time: 30.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840, data reload: false
query1 0.05 0.05 0.06
query2 0.10 0.06 0.06
query3 0.26 0.08 0.08
query4 1.61 0.12 0.12
query5 0.28 0.27 0.25
query6 1.18 0.65 0.64
query7 0.04 0.03 0.03
query8 0.06 0.04 0.04
query9 0.63 0.53 0.51
query10 0.58 0.59 0.58
query11 0.17 0.12 0.12
query12 0.16 0.12 0.12
query13 0.62 0.61 0.64
query14 1.04 1.05 1.02
query15 0.87 0.85 0.87
query16 0.40 0.41 0.40
query17 1.05 1.11 1.04
query18 0.22 0.20 0.20
query19 1.94 1.78 1.86
query20 0.02 0.02 0.01
query21 15.42 0.91 0.57
query22 0.76 1.23 0.70
query23 14.90 1.41 0.64
query24 7.62 0.76 1.06
query25 0.48 0.28 0.08
query26 0.62 0.17 0.14
query27 0.07 0.06 0.06
query28 9.23 1.35 0.93
query29 12.55 3.95 3.36
query30 0.28 0.14 0.14
query31 2.84 0.63 0.40
query32 3.22 0.58 0.48
query33 3.02 3.09 3.17
query34 16.16 5.48 4.88
query35 4.93 4.97 4.91
query36 0.67 0.54 0.51
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.03 0.03 0.03
query40 0.17 0.16 0.15
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 104.58 s
Total hot run time: 30.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384749727
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384384024
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #56739:
URL: https://github.com/apache/doris/pull/56739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3388294506
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3388294534
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384636041
<details>
<summary>ClickBench: <b>Total hot run time: 30.32 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91422908d74895c005c45e4625d8d89aaaad8acc, data reload: false
query1 0.06 0.04 0.05
query2 0.09 0.05 0.05
query3 0.25 0.08 0.09
query4 1.61 0.12 0.12
query5 0.27 0.26 0.26
query6 1.16 0.65 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.05
query9 0.60 0.52 0.51
query10 0.61 0.58 0.58
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.62 0.61 0.61
query14 1.02 1.03 1.01
query15 0.86 0.84 0.85
query16 0.41 0.40 0.39
query17 1.02 1.04 1.05
query18 0.22 0.20 0.20
query19 1.98 1.82 1.83
query20 0.01 0.01 0.02
query21 15.45 0.91 0.57
query22 0.78 1.11 0.74
query23 14.91 1.38 0.61
query24 7.16 0.76 1.43
query25 0.48 0.23 0.10
query26 0.56 0.16 0.13
query27 0.08 0.06 0.05
query28 9.58 1.36 0.93
query29 12.55 3.92 3.23
query30 0.28 0.14 0.11
query31 2.84 0.59 0.39
query32 3.26 0.55 0.46
query33 3.11 3.17 3.13
query34 16.17 5.41 4.86
query35 4.92 4.90 4.87
query36 0.69 0.52 0.51
query37 0.10 0.07 0.08
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.04 0.03
query42 0.05 0.03 0.03
query43 0.05 0.03 0.03
Total cold run time: 104.59 s
Total hot run time: 30.32 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3385354488
# BE Regression && UT Coverage Report
Increment line coverage `96.25% (77/80)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56739_e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56739_e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.21% (23540/33057) |
| Line Coverage | 57.66% (245908/426451) |
| Region Coverage | 52.74% (203994/386778) |
| Branch Coverage | 54.63% (88137/161346) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384600978
<details>
<summary>TPC-DS: <b>Total hot run time: 165939 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91422908d74895c005c45e4625d8d89aaaad8acc, data reload: false
use_consistent_hash_for_external_scan false false 0
use_fix_replica -1 -1 0
use_max_length_of_varchar_in_ctas true true 0
use_one_phase_agg_for_group_concat_with_order false false 0
use_rf_default false false 0
use_v2_rollup false false 0
validate_password_policy NONE NONE 0
version 5.7.99 5.7.99 0
version_comment doris version doris-0.0.0-0f0b63c1cd doris version doris-0.0.0-0f0b63c1cd 0
wait_timeout 28800 28800 0
workload_group 0
============================================
show table status;
Name Engine Version Row_format Rows Avg_row_length Data_length Max_data_length Index_length Data_free Auto_increment Create_time Update_time Check_time Collation Checksum Create_options Comment
catalog_sales Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:55:02 NULL utf-8 NULL NULL
item Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:05 NULL utf-8 NULL NULL
date_dim Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:01 NULL utf-8 NULL NULL
call_center Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:44:01 NULL utf-8 NULL NULL
web_sales Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:53:25 NULL utf-8 NULL NULL
inventory Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:50:32 NULL utf-8 NULL NULL
store Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:01 NULL utf-8 NULL NULL
catalog_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:46:25 NULL utf-8 NULL NULL
time_dim Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:03 NULL utf-8 NULL NULL
household_demographics Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
store_sales Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:59:20 NULL utf-8 NULL NULL
ship_mode Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:05 NULL utf-8 NULL NULL
customer_address Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:41 NULL utf-8 NULL NULL
customer Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:53 NULL utf-8 NULL NULL
web_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:45:43 NULL utf-8 NULL NULL
warehouse Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:01 NULL utf-8 NULL NULL
web_site Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
customer_demographics Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:34 NULL utf-8 NULL NULL
promotion Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
web_page Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:01 NULL utf-8 NULL NULL
store_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:47:09 NULL utf-8 NULL NULL
income_band Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
dbgen_version Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:01 NULL utf-8 NULL NULL
catalog_page Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
reason Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:01 NULL utf-8 NULL NULL
============================================
query1 query2 6956 1678 1713 1678
query3 6763 236 224 224
query4 26822 23904 23607 23607
query5 5166 630 548 548
query6 348 254 237 237
query7 query8 query9 9605 2572 2585 2572
query10 637 353 283 283
query11 15785 14961 14894 14894
query12 query13 query14 12205 9236 9205 9205
query15 219 205 181 181
query16 query17 query18 query19 237 213 211 211
query20 query21 244 141 124 124
query22 4367 4257 3995 3995
query23 34701 34105 34195 34105
query24 11225 2480 2517 2480
query25 821 567 516 516
query26 query27 query28 7659 2221 2310 2221
query29 1456 662 510 510
query30 query31 980 838 750 750
query32 84 74 83 74
query33 query34 query35 836 867 782 782
query36 query37 170 103 87 87
query38 query39 1641 1540 1480 1480
query40 344 143 132 132
query41 query42 151 131 124 124
query43 537 539 499 499
query44 2319 853 869 853
query45 228 202 207 202
query46 966 1014 680 680
query47 1974 1989 1876 1876
query48 query49 857 554 451 451
query50 634 618 429 429
query51 4057 4320 4029 4029
query52 136 108 100 100
query53 query54 query55 150 96 89 89
query56 query57 1223 1198 1146 1146
query58 290 270 271 270
query59 2594 2749 2619 2619
query60 query61 176 159 146 146
query62 793 721 675 675
query63 query64 query65 4013 3971 3966 3966
query66 query67 15646 15226 15092 15092
query68 3189 884 651 651
query69 query70 query71 query72 query73 query74 8922 9129 9047 9047
query75 query76 7235 1178 771 771
query77 552 386 310 310
query78 9488 9478 8979 8979
query79 1711 805 606 606
query80 query81 query82 268 167 144 144
query83 524 269 270 269
query84 310 122 91 91
query85 query86 401 300 314 300
query87 3872 3734 3653 3653
query88 2782 2261 2231 2231
query89 query90 2301 218 217 217
query91 query92 79 71 69 69
query93 query94 query95 query96 298 279 278 278
query97 2949 3031 2897 2897
query98 query99 1538 1496 1284 1284
Total cold run time: 232434 ms
Total hot run time: 165939 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3385015630
# BE UT Coverage Report
Increment line coverage `30.00% (24/80)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840_e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840_e2e4ce4217aa8a4582c2cc1fbcc98cbf87358840/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.49% (17710/33739) |
| Line Coverage | 37.66% (160750/426882) |
| Region Coverage | 32.15% (122793/381950) |
| Branch Coverage | 33.55% (53852/160535) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](predicate) Refactor interface [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56739:
URL: https://github.com/apache/doris/pull/56739#issuecomment-3384292508
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org