You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "weldon washburn (JIRA)" <ji...@apache.org> on 2007/08/27 05:01:30 UTC
[jira] Created: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
cleanup of JVMTI/java.lang.Thread data structures
-------------------------------------------------
Key: HARMONY-4683
URL: https://issues.apache.org/jira/browse/HARMONY-4683
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: weldon washburn
Assignee: weldon washburn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "Pavel Rebriy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523486 ]
Pavel Rebriy commented on HARMONY-4683:
---------------------------------------
Weldon, here are my answers:
1) Yes, Java_java_lang_VMThreadManager_getState() is incorrect, thank you.
2) Yes, it looks reasonable.
3) Yes, I'm taking a look at it, thank for remark.
4) This information is available for JVMTI.
5) Field vm_state has sense only for unattached threads: new or dead. This is its contract.
I think my patch should be fixed and I'm going to create a new JIRA issue with changes.
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch, H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn closed HARMONY-4683.
------------------------------------
Resolution: Fixed
this patch was committed last week. So far, no problems have been reported. I am now closing this JIRA
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch, H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn updated HARMONY-4683:
-------------------------------------
Attachment: H4683.patch
The latest upload include a few fairly minor cosmetic changes
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523294 ]
weldon washburn commented on HARMONY-4683:
------------------------------------------
Pavel,
Some questions:
1)
Does Java_java_lang_VMThreadManager_getState() return the correct answer when a thread is in the NEW state? Will it accidentally report TERMINATED when it is really NEW?
2)
can you rename "hythread_t native_thread;" to something else? There are way too many variables called native_thread. It will make grep work much nicer.
3)
the mod for jthread_unpark() does an assert(hythread_t); What happens if the target thread has terminated and there is no hythread_t? Will this cause an erroneous assert( )?
4)
jthread_detach() -- why does it need to worry about TM_THREAD_STATE_INTERRUPTED if the thread is dead?
5)
vm_state field in java.lang.Thread does not appear to be updated when a thread sleeps or waits.
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn updated HARMONY-4683:
-------------------------------------
Attachment: H4683.patch
I put the hthread_t pointer back in struct VM_thread and re-posted my patch. Let's get the basic regression tests run in the next 24 hours so that I can commit the mods.
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch, H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522928 ]
weldon washburn commented on HARMONY-4683:
------------------------------------------
H4683.patch passes "build test" on my laptop. It is not yet fully tested. Also there is some code cleanup left to do. For some unknown reason I am getting an error when regression test RuntimeTest2 runs with optimizing JIT. It passes with both interpreter and no optimizing jit.
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn updated HARMONY-4683:
-------------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HARMONY-4517
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "Pavel Rebriy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Rebriy updated HARMONY-4683:
----------------------------------
Attachment: H4683.patch
I'm updating initial patch.
There are the changes:
- Fixed comments for TM_THREAD_STATE_* defines, make if more readable.
- Keep native_thread field in VM_thread - it is needed for future aggragate.
- Fixed hythread_park()/hythread_unpark() functions
- Fixed jvmtiThreadGetState() function
The patch is a draft version and needed to check synchronization problems. It just for investigation of topic.
I'm posting a final patch later.
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch, H4683.patch, H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4683) cleanup of JVMTI/java.lang.Thread
data structures
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn updated HARMONY-4683:
-------------------------------------
Attachment: H4683.patch
> cleanup of JVMTI/java.lang.Thread data structures
> -------------------------------------------------
>
> Key: HARMONY-4683
> URL: https://issues.apache.org/jira/browse/HARMONY-4683
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: weldon washburn
> Assignee: weldon washburn
> Attachments: H4683.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.