[jira] [Commented] (KAFKA-2270) incorrect package name in unit tests

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588109#comment-14588109 ] 

Jun Rao commented on KAFKA-2270:
--------------------------------

Thanks for the patch. Got a bunch of compilation errors like the following due to unused imports. Could you remove them?

kafka/core/src/test/scala/unit/kafka/KafkaConfigTest.scala:22: imported `Kafka' is permanently hidden by definition of object Kafka in package kafka
import kafka.Kafka
             ^
kafka/core/src/test/scala/unit/kafka/common/ConfigTest.scala:23: imported `InvalidConfigException' is permanently hidden by definition of class InvalidConfigException in package common
import kafka.common.InvalidConfigException
                    ^
kafka/core/src/test/scala/unit/kafka/common/TopicTest.scala:22: imported `Topic' is permanently hidden by definition of object Topic in package common
import kafka.common.{Topic, InvalidTopicException}
                     ^
kafka/core/src/test/scala/unit/kafka/common/TopicTest.scala:22: imported `InvalidTopicException' is permanently hidden by definition of class InvalidTopicException in package common
import kafka.common.{Topic, InvalidTopicException}


> incorrect package name in unit tests
> ------------------------------------
>
>                 Key: KAFKA-2270
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2270
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Jun Rao
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.8.3
>
>         Attachments: fix-kafka-2270.patch
>
>
> There are a bunch of test files with incorrect package prefix unit.
> core/src/test/scala/unit/kafka/common/ConfigTest.scala:package unit.kafka.common
> core/src/test/scala/unit/kafka/common/TopicTest.scala:package unit.kafka.common
> core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala:package unit.kafka.consumer
> core/src/test/scala/unit/kafka/integration/MinIsrConfigTest.scala:package unit.kafka.integration
> core/src/test/scala/unit/kafka/KafkaConfigTest.scala:package unit.kafka
> core/src/test/scala/unit/kafka/log/LogConfigTest.scala:package unit.kafka.log
> core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala:package unit.kafka.server
> core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala:package unit.kafka.utils
> core/src/test/scala/unit/kafka/utils/CommandLineUtilsTest.scala:package unit.kafka.utils
> core/src/test/scala/unit/kafka/zk/ZKPathTest.scala:package unit.kafka.zk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)