You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by XIAOBING ZHOU <xz...@gmail.com> on 2015/02/25 02:15:29 UTC
Review Request 31395: HIVE-9642: Hive metastore client retries don't
happen consistently for all api calls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31395/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout, the retry via RetryingMetaStoreClient happens only in certain cases.
Retry happens for the getDatabase call in but not for getAllDatabases().
The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException. But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain functions in HMC.
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b4f02fc
Diff: https://reviews.apache.org/r/31395/diff/
Testing
-------
Thanks,
XIAOBING ZHOU
Re: Review Request 31395: HIVE-9642: Hive metastore client retries
don't happen consistently for all api calls
Posted by XIAOBING ZHOU <xz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31395/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 7:23 p.m.)
Review request for hive.
Changes
-------
Patch V2. removd the MetaException Wrapping
Repository: hive-git
Description
-------
When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout, the retry via RetryingMetaStoreClient happens only in certain cases.
Retry happens for the getDatabase call in but not for getAllDatabases().
The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException. But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain functions in HMC.
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 4778bb6
Diff: https://reviews.apache.org/r/31395/diff/
Testing
-------
Thanks,
XIAOBING ZHOU