You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Thomas Jungblut (JIRA)" <ji...@apache.org> on 2011/04/18 11:25:05 UTC

[jira] [Created] (HAMA-379) Setting default values to job.setNumBspTask()

Setting default values to job.setNumBspTask()
---------------------------------------------

                 Key: HAMA-379
                 URL: https://issues.apache.org/jira/browse/HAMA-379
             Project: Hama
          Issue Type: Task
          Components: bsp
    Affects Versions: 0.2.0
         Environment: linux
            Reporter: Thomas Jungblut
            Priority: Minor
             Fix For: 0.3.0


When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:


    11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
    11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0


We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)

This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029809#comment-13029809 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

Can someone please apply this patch on the current trunk and tell me what is wrong? For me this is working.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Comment: was deleted

(was: That seems funny. I'm on rev 1098478.
So what, try again.

When we are going to change the junit tests to work with the LocalBSPRunner we can add a testcase for that too.)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment:     (was: hama-379-v3.patch)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Attachment: HAMA-379_v07.patch

This patch fixs that problem.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029841#comment-13029841 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

This will fix the problem described in the issue, so I'm +1 for that.

Thanks for helping :)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029825#comment-13029825 ] 

Thomas Jungblut edited comment on HAMA-379 at 5/6/11 8:24 AM:
--------------------------------------------------------------

You mean in the case someone submits a job and don't won't to run a task?:D

EDIT: maxtasks <> user entered tasks. Sorry for that, it's to early in the morning.

      was (Author: thomas.jungblut):
    You mean in the case someone submits a job and don't won't to run a task?:D
  
> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Open  (was: Patch Available)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Status: Patch Available  (was: Open)

Rescheduling.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Attachment: hama-379-v5.patch

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment: hama-379-v2.patch

updated this to work with current trunk, updated the localbsprunner to return the real amount of available trackers (num of processor cores) to avoid log warnings.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Status: Open  (was: Patch Available)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut reassigned HAMA-379:
------------------------------------

    Assignee: Thomas Jungblut

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Status: Patch Available  (was: Open)

Running v06 patch through hudson

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment: hama-379.patch

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Thomas!

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment: hama-379-v4.patch

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379-v4.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment: hama-379-v3.patch

That seems funny. I'm on rev 1098478.
So what, try again.

When we are going to change the junit tests to work with the LocalBSPRunner we can add a testcase for that too.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029859#comment-13029859 ] 

Hudson commented on HAMA-379:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12478390/HAMA-379_v07.patch
against trunk revision 1098478.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 6 new or modified tests.

    core tests -1.  The patch failed core unit tests.

Changes : http://builds.apache.org/hudson/job/Hama-Patch/330/changes/
Console output: http://builds.apache.org/hudson/job/Hama-Patch/330/console

This message is automatically generated.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025162#comment-13025162 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

Added the upper and lower bound to the submitInternal method.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029818#comment-13029818 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

Strange. This is the right trunk: https://svn.apache.org/repos/asf/incubator/hama/trunk, isn't it?
And the latest revision is 1098478.

Or are we currently in a branch?

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029825#comment-13029825 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

You mean in the case someone submits a job and don't won't to run a task?:D

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment: hama-379-v4.patch

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment:     (was: hama-379-v3.patch)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Open  (was: Patch Available)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Patch Available  (was: Open)

once again..

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029836#comment-13029836 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

Usually they work fine. I'll strip them the next time.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Open  (was: Patch Available)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379-v4.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029829#comment-13029829 ] 

Edward J. Yoon commented on HAMA-379:
-------------------------------------

During a TestBSPMasterGroomServer is running, clusterStatus.getMaxTasks() returns zero.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029814#comment-13029814 ] 

ChiaHung Lin commented on HAMA-379:
-----------------------------------

Not very sure if this is the case. 

The current revision number in trunk shows `Revision: 1100119,` which is different from the patch - revision 1099120.

Applying the patch to the trunk produces error below:

(Stripping trailing CRs from patch.)
patching file src/java/org/apache/hama/bsp/LocalBSPRunner.java
Hunk #1 FAILED at 122.
1 out of 1 hunk FAILED -- saving rejects to file src/java/org/apache/hama/bsp/LocalBSPRunner.java.rej
(Stripping trailing CRs from patch.)



> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Attachment: hama-379-v6.patch

What if maxTasks is zero?

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029831#comment-13029831 ] 

Thomas Jungblut commented on HAMA-379:
--------------------------------------

Okay, I wasn't aware of it. Thank you very much Edward.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Patch Available  (was: Open)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379-v4.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment:     (was: hama-379-v4.patch)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-379:
--------------------------------

    Status: Open  (was: Patch Available)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029834#comment-13029834 ] 

Edward J. Yoon commented on HAMA-379:
-------------------------------------

And the auto-generated comments seems problematic in your patch.

{code}
### Eclipse Workspace Patch 1.0
#P apache-hama
{code}

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029839#comment-13029839 ] 

Edward J. Yoon commented on HAMA-379:
-------------------------------------

Thomas, Please review HAMA-379_v07.patch and let me know if it should be committed. :)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HAMA-379_v07.patch, hama-379-v4.patch, hama-379-v5.patch, hama-379-v6.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment:     (was: hama-379-v2.patch)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Attachment:     (was: hama-379.patch)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Patch Available  (was: Open)

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379-v3.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028311#comment-13028311 ] 

Hudson commented on HAMA-379:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12478066/hama-379-v2.patch
against trunk revision 1098478.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    patch -1.  The patch command could not apply the patch.

Console output: http://builds.apache.org/hudson/job/Hama-Patch/327/console

This message is automatically generated.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029808#comment-13029808 ] 

Hudson commented on HAMA-379:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12478384/hama-379-v4.patch
against trunk revision 1098478.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    patch -1.  The patch command could not apply the patch.

Console output: http://builds.apache.org/hudson/job/Hama-Patch/328/console

This message is automatically generated.

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v4.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HAMA-379) Setting default values to job.setNumBspTask()

Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Jungblut updated HAMA-379:
---------------------------------

    Status: Patch Available  (was: Open)

submitting this to hudson

> Setting default values to job.setNumBspTask()
> ---------------------------------------------
>
>                 Key: HAMA-379
>                 URL: https://issues.apache.org/jira/browse/HAMA-379
>             Project: Hama
>          Issue Type: Task
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: linux
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: hama-379-v2.patch, hama-379.patch
>
>
> When a user does not explicitly sets the number of BSP tasks in his own jobs the job will hang forever with this output:
>     11/04/17 20:07:50 INFO bsp.BSPJobClient: Running job: job_201104172007_0001
>     11/04/17 20:07:53 INFO bsp.BSPJobClient: Current supersteps number: 0
> We should provide a check that will reject wrong values: 1 > numOfTasks > numberOfGrooms (is this upper bound right or can multiple tasks of the same job run on the same groom?)
> This could be implemented in the method "submitJobInternal" of the BSPJobClient. We should add an info log statement if we changed the value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira