You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2026/10/12 09:08:03 UTC
[PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
laurentgo opened a new pull request, #1341:
URL: https://github.com/apache/arrow-java/pull/1341
## What's Changed
The Linux JNI jobs fail installing Archery with `Python < 3.11 is not supported`, because `docker compose run vcpkg-jni` pulls a stale published image built on an `apache/arrow` `cpp-jni` base that still had Python 3.10 first on `PATH`.
The `vcpkg-jni` image tag only depended on the `VCPKG` pin, so a new base image did not result in a new image.
- Add `VCPKG_JNI_REVISION` to `.env` and append it to the `vcpkg-jni` image tag (and its `cache_from`) in `compose.yaml`. The previous image is left untouched; the new tag does not exist yet, so Compose builds it on top of the current base. It is published by the existing push step on the next successful run on `main`.
- Bump `VCPKG_JNI_REVISION` whenever the base image changes without a `VCPKG` bump.
AI assistance (Claude Code) was used during development; the complete diff was reviewed by the author.
Closes #1340.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#discussion_r4247841162
##########
.github/workflows/rc.yml:
##########
Review Comment:
How about always building with cache instead of introducing `VCPKG_JNI_REVISION`?
```suggestion
docker compose build --pull vcpkg-jni
docker compose run vcpkg-jni
```
If we use `VCPKG_JNI_REVISION`, we need to update it manually when apache/arrow changes something without changing `VCPKG`. If we build with cache, we don't need it. (I hope that building with cache doesn't increase CI time.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#issuecomment-6141379242
I'm rebasing this PR onto `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Always build the vcpkg-jni image and use the right cpp-jni base tag [arrow-java]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo merged PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#issuecomment-6126308234
See #1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on code in PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#discussion_r4248062576
##########
.github/workflows/rc.yml:
##########
Review Comment:
I guess this is another option, but it would probably add 30~60s per run because we are rebuilding the image each time. That said it seems to be the behavior of archery docker as well (and I wanted to do a followup change to switch to archery)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#issuecomment-6126052063
Looks like the latest ubuntu image comes with maven 3.10.0 which causes some incompatibility with the current develocity plugin. Upgrading the plugin seems to fix the issue, so let me open a separate issue and pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1340: [CI][JNI] Rebuild the vcpkg-jni image on a new tag to pick up Python 3.11 [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #1341:
URL: https://github.com/apache/arrow-java/pull/1341#discussion_r4252575720
##########
.github/workflows/rc.yml:
##########
Review Comment:
I think that we should not use Archery for our `compose.yaml` because `archery docker ...` is designed only for apache/arrow... For example, it requires `x-hierarchy`: https://github.com/apache/arrow/blob/9b34c4a6a8856212b885f6a1e934795af04f3192/compose.yaml#L106-L187
It will introduce another complexity...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org