You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/10/14 07:40:28 UTC

[GitHub] [couchdb-fauxton] willholley commented on a change in pull request #1233: Explicitly install peerdependencies

willholley commented on a change in pull request #1233: Explicitly install peerdependencies
URL: https://github.com/apache/couchdb-fauxton/pull/1233#discussion_r334355087
 
 

 ##########
 File path: package.json
 ##########
 @@ -34,6 +34,8 @@
     "@babel/preset-react": "^7.0.0",
     "@babel/register": "^7.4.4",
     "@webcomponents/url": "~0.7.1",
+    "acorn": "^6.0.0",
 
 Review comment:
   Comments aren't allowed in JSON so I think we need to rely on Git blame and additional CI checks here. I'm going to look at how we can catch this as part of the Fauxton CI rather than waiting until a CouchDB release to find the error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services