[jira] [Commented] (KAFKA-6288) Broken symlink interrupts scanning the plugin path

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341880#comment-16341880 ] 

ASF GitHub Bot commented on KAFKA-6288:
---------------------------------------

kkonstantine opened a new pull request #4481: KAFKA-6288: Broken symlink interrupts scanning of the plugin path
URL: https://github.com/apache/kafka/pull/4481
 
 
   Submitting a fail safe fix for rare IOExceptions on symbolic links. 
   
   The fix is submitted without a test case since it does seem easy to reproduce such type of failures (just having a broken symbolic link does not reproduce the issue) and it's considered pretty low risk.  
   
   If accepted, needs to be ported at least to 1.0, if not 0.11
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Broken symlink interrupts scanning the plugin path
> --------------------------------------------------
>
>                 Key: KAFKA-6288
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6288
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 1.0.0
>            Reporter: Yeva Byzek
>            Assignee: Konstantine Karantasis
>            Priority: Major
>         Attachments: 6288.v1.txt
>
>
> KAFKA-6087 introduced support for scanning relative symlinks in the plugin path. However, if a relative symlink points to a target that doesn't exist, then scanning the plugin path is interrupted. The consequence is that the unscanned connectors in the plugin path may effectively not be usable.
> Desired behavior is that the symlink with the non-existent target is skipped and scanning the plugin path continues.
> Example of error message:
> {noformat}
> [2017-11-30 20:19:26,226] ERROR Could not get listing for plugin path: /usr/share/java. Ignoring. (org.apache.kafka.connect.runtime.isolation.DelegatingClassLoader:170)
> java.nio.file.NoSuchFileException: /usr/share/java/name.jar
> 	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
> 	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
> 	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
> 	at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:837)
> 	at org.apache.kafka.connect.runtime.isolation.PluginUtils.pluginUrls(PluginUtils.java:241)
> 	at org.apache.kafka.connect.runtime.isolation.DelegatingClassLoader.registerPlugin(DelegatingClassLoader.java:181)
> 	at org.apache.kafka.connect.runtime.isolation.DelegatingClassLoader.initLoaders(DelegatingClassLoader.java:153)
> 	at org.apache.kafka.connect.runtime.isolation.Plugins.<init>(Plugins.java:47)
> 	at org.apache.kafka.connect.cli.ConnectDistributed.main(ConnectDistributed.java:70)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)