You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by sn...@apache.org on 2023/03/10 08:55:39 UTC
[pinot] branch master updated: Make startReplaceSegments() more robust for NPE (#10403)
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dadd42cff1 Make startReplaceSegments() more robust for NPE (#10403)
dadd42cff1 is described below
commit dadd42cff16cb8f4b7ec510ad73455a198b60e37
Author: Jiapeng Tao <ji...@linkedin.com>
AuthorDate: Fri Mar 10 00:55:30 2023 -0800
Make startReplaceSegments() more robust for NPE (#10403)
---
.../apache/pinot/controller/helix/core/PinotHelixResourceManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
index 48418f2bda..65387ecc46 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
@@ -3369,7 +3369,7 @@ public class PinotHelixResourceManager {
// Add segments for proactive clean-up.
segmentsToCleanUp.addAll(segmentsToForEntryToRevert);
} else if (lineageEntry.getState() == LineageEntryState.COMPLETED
- && IngestionConfigUtils.getBatchSegmentIngestionType(tableConfig).equalsIgnoreCase("REFRESH")
+ && "REFRESH".equalsIgnoreCase(IngestionConfigUtils.getBatchSegmentIngestionType(tableConfig))
&& CollectionUtils.isEqualCollection(segmentsFrom, lineageEntry.getSegmentsTo())) {
// This part of code assumes that we only allow at most 2 data snapshots at a time by proactively
// deleting the older snapshots (for REFRESH tables).
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org