[4/6] incubator-impala git commit: IMPALA-5307: Part 3: remove TODO from RCFile

[jr...@apache.org]

IMPALA-5307: Part 3: remove TODO from RCFile

Our RCFile implementations already copies out data (it sets
set_contains_tuple_data to false). Remove a TODO that suggests undoing
this. The current implementation is suboptimal but improving RCFile
performance is not a priority.

Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Reviewed-on: http://gerrit.cloudera.org:8080/8151
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/a93b7c52
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/a93b7c52
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/a93b7c52

Branch: refs/heads/master
Commit: a93b7c52bf17838bcbfeb5002b982f213df4be31
Parents: c1781b7
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Tue Sep 26 23:41:48 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Thu Sep 28 21:54:39 2017 +0000

----------------------------------------------------------------------
 be/src/exec/hdfs-rcfile-scanner.cc | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a93b7c52/be/src/exec/hdfs-rcfile-scanner.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/hdfs-rcfile-scanner.cc b/be/src/exec/hdfs-rcfile-scanner.cc
index 6851bd6..2ea8229 100644
--- a/be/src/exec/hdfs-rcfile-scanner.cc
+++ b/be/src/exec/hdfs-rcfile-scanner.cc
@@ -433,7 +433,6 @@ Status HdfsRCFileScanner::ReadColumnBuffers() {
       uint8_t* uncompressed_data;
       RETURN_IF_FALSE(stream_->ReadBytes(
           column.buffer_len, &uncompressed_data, &parse_status_));
-      // TODO: this is bad.  Remove this copy.
       memcpy(row_group_buffer_ + column.start_offset,
           uncompressed_data, column.buffer_len);
     }