You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by sb...@apache.org on 2014/07/21 04:00:10 UTC

git commit: pull request feedback

Repository: incubator-streams
Updated Branches:
  refs/heads/STREAMS-115 b7a65e1ea -> 1ac7fc789


pull request feedback


Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/1ac7fc78
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/1ac7fc78
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/1ac7fc78

Branch: refs/heads/STREAMS-115
Commit: 1ac7fc789acef34e988335cbba250e516e9bb6aa
Parents: b7a65e1
Author: Steve Blackmon <sb...@w2odigital.com>
Authored: Sun Jul 20 20:59:28 2014 -0500
Committer: Steve Blackmon <sb...@w2odigital.com>
Committed: Sun Jul 20 20:59:28 2014 -0500

----------------------------------------------------------------------
 .../apache/streams/twitter/provider/TwitterErrorHandler.java | 8 ++++++--
 .../streams/twitter/provider/TwitterTimelineProvider.java    | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/1ac7fc78/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java
index 3021701..448f6ae 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterErrorHandler.java
@@ -43,7 +43,9 @@ public class TwitterErrorHandler
                 LOGGER.warn("Rate Limit Exceeded");
                 try {
                     Thread.sleep(retry);
-                } catch (InterruptedException e1) {}
+                } catch (InterruptedException e1) {
+                    Thread.currentThread().interrupt();
+                }
                 return 1;
             }
             else if(e.isCausedByNetworkIssue())
@@ -52,7 +54,9 @@ public class TwitterErrorHandler
                 LOGGER.info("{} - {}", e.getExceptionCode(), e.getLocalizedMessage());
                 try {
                     Thread.sleep(retry);
-                } catch (InterruptedException e1) {}
+                } catch (InterruptedException e1) {
+                    Thread.currentThread().interrupt();
+                }
                 return 1;
             }
             else if(e.isErrorMessageAvailable())

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/1ac7fc78/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
index 538e789..23b38bf 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
@@ -279,7 +279,7 @@ public class TwitterTimelineProvider implements StreamsProvider, Serializable {
                 // screen name list
                 try {
                     ids.add(Long.parseLong(potentialScreenName));
-                } catch (Exception e) {
+                } catch (NumberFormatException e) {
                     screenNames.add(potentialScreenName);
                 }