[GitHub] [netbeans] mbien commented on a diff in pull request #3884: Validate external snippet attributes like file, class, region to check for improper attribute values(JEP 413)

[GitBox <gi...@apache.org>]

mbien commented on code in PR #3884:
URL: https://github.com/apache/netbeans/pull/3884#discussion_r868564327


##########
java/java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java:
##########
@@ -5004,7 +5009,31 @@ private int diffSince(DCDocComment doc, DCSince oldT, DCSince newT, int[] elemen
         }
         return elementBounds[1];
     }
-    
+//    

Review Comment:
   since its a private method, I think it should be either removed or simply left there (if there are plans to use it later). 
   
   Commenting big code blocks out with `//` is not optimal for version control, `/**/` would be better since it produces less merge conflicts due to easier automated diff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists