You are viewing a plain text version of this content. The canonical link for it is here.
Posted to portalapps-dev@portals.apache.org by wo...@apache.org on 2019/04/07 02:18:44 UTC

svn commit: r1857060 - in /portals/applications/webcontent/trunk: content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java pom.xml

Author: woonsan
Date: Sun Apr  7 02:18:44 2019
New Revision: 1857060

URL: http://svn.apache.org/viewvc?rev=1857060&view=rev
Log:
APA-74: upgrading htmlcleaner to 2.22, the latest.

Modified:
    portals/applications/webcontent/trunk/content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java
    portals/applications/webcontent/trunk/pom.xml

Modified: portals/applications/webcontent/trunk/content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java
URL: http://svn.apache.org/viewvc/portals/applications/webcontent/trunk/content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java?rev=1857060&r1=1857059&r2=1857060&view=diff
==============================================================================
--- portals/applications/webcontent/trunk/content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java (original)
+++ portals/applications/webcontent/trunk/content-rewriter/src/test/java/org/apache/portals/applications/webcontent2/rewriter/HtmlCleanerContentRewriterTest.java Sun Apr  7 02:18:44 2019
@@ -16,9 +16,6 @@
  */
 package org.apache.portals.applications.webcontent2.rewriter;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
@@ -42,6 +39,9 @@ import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
 public class HtmlCleanerContentRewriterTest
 {
 
@@ -115,6 +115,7 @@ public class HtmlCleanerContentRewriterT
 
                         if (href != null) 
                         {
+                            tag.removeAttribute("href");
                             tag.addAttribute("href", siteUrl + StringUtils.removeStart(href, "./"));
                         }
                     }

Modified: portals/applications/webcontent/trunk/pom.xml
URL: http://svn.apache.org/viewvc/portals/applications/webcontent/trunk/pom.xml?rev=1857060&r1=1857059&r2=1857060&view=diff
==============================================================================
--- portals/applications/webcontent/trunk/pom.xml (original)
+++ portals/applications/webcontent/trunk/pom.xml Sun Apr  7 02:18:44 2019
@@ -40,7 +40,7 @@
     <slf4j.version>1.5.6</slf4j.version>
     <junit.version>4.11</junit.version>
     <easymock.version>3.2</easymock.version>
-    <htmlcleaner.version>2.8</htmlcleaner.version>
+    <htmlcleaner.version>2.22</htmlcleaner.version>
     <httpcomponents-httpcore.version>4.4.11</httpcomponents-httpcore.version>
     <httpcomponents-httpclient.version>4.5.8</httpcomponents-httpclient.version>
     <jcip-annotations.version>1.0</jcip-annotations.version>