[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437425
 
 

 ##########
 File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
 ##########
 @@ -633,7 +637,10 @@ final void addToMaxSteps(int steps) {
         }
 	
         void paint() {
-            image.paintIcon(comp, graphics, 0, 0);
+            // loadContentIcon may return a null image
+            if (image != null) {
 
 Review comment:
   Yes, reviewing the initialization of image, this one can be null if the graphic file is not found. So this is a good check to include. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists