[jira] [Resolved] (HIVE-23102) waitForCompactionToFinish can potentially wait for too long

["Karen Coppage (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karen Coppage resolved HIVE-23102.
----------------------------------
    Resolution: Duplicate

Fixed with HIVE-23832

> waitForCompactionToFinish can potentially wait for too long
> -----------------------------------------------------------
>
>                 Key: HIVE-23102
>                 URL: https://issues.apache.org/jira/browse/HIVE-23102
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltán Borók-Nagy
>            Priority: Major
>
> AlterTableCompactOperation.waitForCompactionToFinish() has the following code fragment:
>  
> {noformat}
>  //double wait time until 5min
>  waitTimeMs = waitTimeMs*2;
>  waitTimeMs = Math.max(waitTimeMs, waitTimeOut);
> {noformat}
> Based on the comment ("double wait time until 5min") I think it should use Math.min() instead of Math.max().
> It also affects the runtime of Impala tests that use Hive compaction, because they hang for at least 5 mins each time we compact a table. Workaround to this is to configure the wait time to a lower value.
> But still, from the comment I think the original intention of the code was to put an upper bound to the wait time, and not a lower bound.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)