[GitHub] [kafka] dajac commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #10757:
URL: https://github.com/apache/kafka/pull/10757#discussion_r638806738



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2011,7 +2011,11 @@ object Log extends Logging {
       logDirFailureChannel,
       config.messageFormatVersion.recordVersion,
       s"[Log partition=$topicPartition, dir=${dir.getParent}] ")
-    val producerStateManager = new ProducerStateManager(topicPartition, dir, maxProducerIdExpirationMs)
+    val producerStateManager = new ProducerStateManager(
+      topicPartition,
+      dir,
+      maxProducerIdExpirationMs,
+      time)

Review comment:
       Both are equivalent for me. I found that the line was getting too long with the addition of `time` so I broke it down that way to stay inline with `LogLoader.load` below. Would you prefer to keep it on one line instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org