You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/26 12:46:20 UTC
[GitHub] [ozone] sadanand48 opened a new pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
sadanand48 opened a new pull request #2770:
URL: https://github.com/apache/ozone/pull/2770
## What changes were proposed in this pull request?
Add option to write files via streaming api in ofs and o3fs
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5743
## How was this patch tested?
Existing FS tests. Streaming flag is set to true in branch HDDS-4454.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on a change in pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #2770:
URL: https://github.com/apache/ozone/pull/2770#discussion_r739101010
##########
File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -259,6 +260,13 @@ public FSDataOutputStream createNonRecursive(Path path,
private FSDataOutputStream createOutputStream(String key, short replication,
boolean overwrite, boolean recursive) throws IOException {
+ boolean isRatisStreamingEnabled = getConf().getBoolean(
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE,
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE_DEFAULT);
Review comment:
Let's use a different conf, say OZONE_FS_DATASTREAM_ENABLE. OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE is for container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo merged pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #2770:
URL: https://github.com/apache/ozone/pull/2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a change in pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on a change in pull request #2770:
URL: https://github.com/apache/ozone/pull/2770#discussion_r739241117
##########
File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -259,6 +260,13 @@ public FSDataOutputStream createNonRecursive(Path path,
private FSDataOutputStream createOutputStream(String key, short replication,
boolean overwrite, boolean recursive) throws IOException {
+ boolean isRatisStreamingEnabled = getConf().getBoolean(
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE,
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE_DEFAULT);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
captainzmc commented on pull request #2770:
URL: https://github.com/apache/ozone/pull/2770#issuecomment-953600661
Hi, @sadanand48 thanks for the patch. Can you rebase branch/HDDS-4454 and recommit the code? Now this PR has some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2770:
URL: https://github.com/apache/ozone/pull/2770#issuecomment-955132069
@sadanand48 , TestOzoneConfigurationFields failed. It is related to the new conf. Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a change in pull request #2770: HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs.
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on a change in pull request #2770:
URL: https://github.com/apache/ozone/pull/2770#discussion_r739236763
##########
File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -259,6 +260,13 @@ public FSDataOutputStream createNonRecursive(Path path,
private FSDataOutputStream createOutputStream(String key, short replication,
boolean overwrite, boolean recursive) throws IOException {
+ boolean isRatisStreamingEnabled = getConf().getBoolean(
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE,
+ OzoneConfigKeys.DFS_CONTAINER_RATIS_DATASTREAM_ENABLE_DEFAULT);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org