You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/13 04:12:16 UTC

[kudu-CR] bitmap: add copy operation 

Hello Mike Percy, Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13007

to review the following change.


Change subject: bitmap: add copy operation
......................................................................

bitmap: add copy operation

This can be used to copy an arbitrary subsection of a bitmap into another
bitmap, overwriting its contents.

Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
---
M src/kudu/common/partial_row.cc
M src/kudu/util/bitmap-test.cc
M src/kudu/util/bitmap.cc
M src/kudu/util/bitmap.h
4 files changed, 130 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13007/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
Gerrit-Change-Number: 13007
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] bitmap: add copy operation

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13007 )

Change subject: bitmap: add copy operation
......................................................................

bitmap: add copy operation

This can be used to copy an arbitrary subsection of a bitmap into another
bitmap, overwriting its contents.

Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
Reviewed-on: http://gerrit.cloudera.org:8080/13007
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/common/partial_row.cc
M src/kudu/util/bitmap-test.cc
M src/kudu/util/bitmap.cc
M src/kudu/util/bitmap.h
4 files changed, 130 insertions(+), 10 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mike Percy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
Gerrit-Change-Number: 13007
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] bitmap: add copy operation

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13007

to look at the new patch set (#3).

Change subject: bitmap: add copy operation
......................................................................

bitmap: add copy operation

This can be used to copy an arbitrary subsection of a bitmap into another
bitmap, overwriting its contents.

Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
---
M src/kudu/common/partial_row.cc
M src/kudu/util/bitmap-test.cc
M src/kudu/util/bitmap.cc
M src/kudu/util/bitmap.h
4 files changed, 130 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13007/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c1206306d7e06f6a3eb6854d1a8b4cc09600ca0
Gerrit-Change-Number: 13007
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>