[GitHub] [spark] yaooqinn edited a comment on issue #26995: [SPARK-30341][SQL] Overflow check for interval arithmetic operations

[GitBox <gi...@apache.org>]

yaooqinn edited a comment on issue #26995: [SPARK-30341][SQL] Overflow check for interval arithmetic operations
URL: https://github.com/apache/spark/pull/26995#issuecomment-568663921
 
 
   > Why did you target interval only in this pr? If we change the overflow behaivour for arighmetic operatrions, I think we need to carefully handle it cuz it has impacts on the existing behaivours.
   
   Because the numeric types are handled in arithmetics properly in both ANSI or non-ANSI mode based on my check. This PR tries to fix the interval to follow what the numeric ones do. Thus, the behavior impacts are limited to the interval operations as the pr description says.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org