[GitHub] carbondata pull request #1481: [CARBONDATA-1576] Added create datamap parser...

[xubo245 <gi...@git.apache.org>]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r164042794
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -0,0 +1,68 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.execution.command.datamap
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.spark.sql._
    +import org.apache.spark.sql.catalyst.TableIdentifier
    +import org.apache.spark.sql.execution.command._
    +import org.apache.spark.sql.execution.command.preaaggregate.{CreatePreAggregateTableCommand, PreAggregateUtil}
    +
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
    +
    +/**
    + * Below command class will be used to create datamap on table
    + * and updating the parent table about the datamap information
    + *
    + * @param queryString
    + */
    +case class CarbonCreateDataMapCommand(
    +    dataMapName: String,
    +    tableIdentifier: TableIdentifier,
    +    dmClassName: String,
    +    dmproperties: Map[String, String],
    +    queryString: Option[String])
    +  extends RunnableCommand with SchemaProcessCommand {
    +
    +  override def run(sparkSession: SparkSession): Seq[Row] = {
    +    processSchema(sparkSession)
    +  }
    +
    +  override def processSchema(sparkSession: SparkSession): Seq[Row] = {
    +    val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +    if (dmClassName.equals("org.apache.carbondata.datamap.AggregateDataMapHandler") ||
    +        dmClassName.equalsIgnoreCase("preaggregate")) {
    +      CreatePreAggregateTableCommand(dataMapName,
    +        tableIdentifier,
    +        dmClassName,
    +        dmproperties,
    +        queryString.get).run(sparkSession)
    +    } else {
    --- End diff --
    
    Why do this? Do carbon support create datamap ... using 'abc.class' now?


---