[jira] Resolved: (WICKET-612) HeaderContributor forces relative URL

["Alastair Maw (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw resolved WICKET-612.
---------------------------------

    Resolution: Fixed

Yep, I think this is a reasonable use-case, even if it might confuse some users. I've updated the javadoc appropriately, so hopefully this will be mitigated.

Fixed in r544124.

> HeaderContributor forces relative URL
> -------------------------------------
>
>                 Key: WICKET-612
>                 URL: https://issues.apache.org/jira/browse/WICKET-612
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Jeremy Thomerson
>            Assignee: Alastair Maw
>            Priority: Minor
>             Fix For: 1.3.0-beta2
>
>         Attachments: wicket-patch-612.patch
>
>
> I consider this a bug, and was wondering if you do as well...  If so, I will open a JIRA and attach a patch for it.  Just let me know.
> In my 1.2.6 app, I have the following line:
> add(HeaderContributor.forCss("/resources/styles/global.css"));
> which generates this in the markup (correctly):
> <link rel ="stylesheet" type="text/css" href="/resources/css/global.css" ></link>
> In 1.3, it generates this in the markup (incorrectly):
> <link rel ="stylesheet" type="text/css" href="../../..//resources/styles/global.css" ></link>
> This is because of the change to have everything with relative URLs, I am assuming.  But, I don't want a relative URL, I want an absolute one.  I'm thinking that the following change would be appropriate:
> HeaderContributor.java (26)
> if (location.startsWith("http://") || location.startsWith("https://"))
> changed to:
> if (location.startsWith("http://") || location.startsWith("https://") || location.startsWith("/"))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.