You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by eyalfa <gi...@git.apache.org> on 2018/06/04 05:45:46 UTC

[GitHub] spark pull request #21369: [SPARK-22713][CORE] ExternalAppendOnlyMap leaks w...

Github user eyalfa commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21369#discussion_r192631230
  
    --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala ---
    @@ -414,7 +415,106 @@ class ExternalAppendOnlyMapSuite extends SparkFunSuite with LocalSparkContext {
         sc.stop()
       }
     
    -  test("external aggregation updates peak execution memory") {
    +  test("SPARK-22713 spill during iteration leaks internal map") {
    +    val size = 1000
    +    val conf = createSparkConf(loadDefaults = true)
    +    sc = new SparkContext("local-cluster[1,1,1024]", "test", conf)
    +    val map = createExternalMap[Int]
    --- End diff --
    
    @cloud-fan , can we move on with this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org