You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by justin coffey <j....@criteo.com> on 2014/05/14 11:16:29 UTC
Review Request 21430: HIVE-6994 - parquet-hive createArray strips null
elements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21430/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
The createArray method in ParquetHiveSerDe strips null values from resultant ArrayWritables.
This patch:
- removes an incorrect if null check in createArray
- simplifies ParquetHiveSerDe
- total refactor of TestParquetHiveSerDe for better test coverage and easier regression testing
Diffs
-----
data/files/parquet_create.txt ccd48ee
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 3b56fc7
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION
ql/src/test/queries/clientpositive/parquet_create.q 0b976bd
ql/src/test/results/clientpositive/parquet_create.q.out 3220be5
Diff: https://reviews.apache.org/r/21430/diff/
Testing
-------
Thanks,
justin coffey
Re: Review Request 21430: HIVE-6994 - parquet-hive createArray strips null
elements
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21430/#review42983
-----------------------------------------------------------
Ship it!
- Szehon Ho
On May 14, 2014, 9:16 a.m., justin coffey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21430/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 9:16 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The createArray method in ParquetHiveSerDe strips null values from resultant ArrayWritables.
>
> This patch:
> - removes an incorrect if null check in createArray
> - simplifies ParquetHiveSerDe
> - total refactor of TestParquetHiveSerDe for better test coverage and easier regression testing
>
>
> Diffs
> -----
>
> data/files/parquet_create.txt ccd48ee
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 3b56fc7
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION
> ql/src/test/queries/clientpositive/parquet_create.q 0b976bd
> ql/src/test/results/clientpositive/parquet_create.q.out 3220be5
>
> Diff: https://reviews.apache.org/r/21430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> justin coffey
>
>