You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/02 00:49:48 UTC
Re: Review Request 45200: Duplicate flags with keywork 'slave' on
master side.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
-----------------------------------------------------------
Can you call this out in the CHANGELOG too please?
Also, all of the old flags should print a deprecation warning (when a user does --help on the binary or starts the binary with a deprecated flag) and direct users to the new flags. Can you make that change?
- Vinod Kone
On March 23, 2016, 7:39 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 7:39 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [https://issues.apache.org/jira/browse/MESOS-3781]
>
>
> Diffs
> -----
>
> src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c
> src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45200/diff/
>
>
> Testing
> -------
>
> ./configure --with-network-isolator
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 45200: Duplicate flags with keywork 'slave' on
master side.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 1, 2016, 10:49 p.m., Vinod Kone wrote:
> > Can you call this out in the CHANGELOG too please?
> >
> > Also, all of the old flags should print a deprecation warning (when a user does --help on the binary or starts the binary with a deprecated flag) and direct users to the new flags. Can you make that change?
>
> Jay Guo wrote:
> Sure, will do.
Any update on this?
Also the description should be more meaningful than the bug id. Move the bug id to "bugs" field.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
-----------------------------------------------------------
On March 23, 2016, 7:39 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 7:39 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [https://issues.apache.org/jira/browse/MESOS-3781]
>
>
> Diffs
> -----
>
> src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c
> src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45200/diff/
>
>
> Testing
> -------
>
> ./configure --with-network-isolator
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 45200: Duplicate flags with keywork 'slave' on
master side.
Posted by Jay Guo <gu...@cn.ibm.com>.
> On April 1, 2016, 10:49 p.m., Vinod Kone wrote:
> > Can you call this out in the CHANGELOG too please?
> >
> > Also, all of the old flags should print a deprecation warning (when a user does --help on the binary or starts the binary with a deprecated flag) and direct users to the new flags. Can you make that change?
Sure, will do.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
-----------------------------------------------------------
On March 23, 2016, 7:39 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 7:39 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [https://issues.apache.org/jira/browse/MESOS-3781]
>
>
> Diffs
> -----
>
> src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c
> src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45200/diff/
>
>
> Testing
> -------
>
> ./configure --with-network-isolator
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 45200: Duplicate flags with keyword 'slave'.
Posted by Jay Guo <gu...@cn.ibm.com>.
> On April 1, 2016, 10:49 p.m., Vinod Kone wrote:
> > Can you call this out in the CHANGELOG too please?
> >
> > Also, all of the old flags should print a deprecation warning (when a user does --help on the binary or starts the binary with a deprecated flag) and direct users to the new flags. Can you make that change?
>
> Jay Guo wrote:
> Sure, will do.
>
> Vinod Kone wrote:
> Any update on this?
>
> Also the description should be more meaningful than the bug id. Move the bug id to "bugs" field.
CHANGELOG is updated. Deprecation warning is placed in --help, under those flags with 'slave'. Also when user starts the binary with deprecated flags, LOG(WARNING) reflects the deprecation as well. Please take a look! Thanks!
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
-----------------------------------------------------------
On April 11, 2016, 6:45 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 6:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It duplicates master/slave flags that contain 'slave'. This is
> part of the epic replacing all keyword 'slave' with 'agent' in
> current codebase.
>
>
> Diffs
> -----
>
> CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3
> src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa
> src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842
> src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
> src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631
> src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45200/diff/
>
>
> Testing
> -------
>
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
>
>
> Thanks,
>
> Jay Guo
>
>