You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2007/03/31 05:49:49 UTC

VOTE accept fix to WICKET-432 into 1.2.x

the subject says it all.

i kinda jumped the gun on this one and committed already by mistake :( my
appologies.

if the vote doesnt pass i will revert it.

-igor

Re: VOTE accept fix to WICKET-432 into 1.2.x

Posted by Martijn Dashorst <ma...@gmail.com>.
On 3/31/07, Martijn Dashorst <ma...@gmail.com> wrote:
> How does this affect people that have overridden Page.onAttach() but
> don't call super()?

I saw that you fixed that first commit. +1

Martijn

-- 
Learn Wicket at ApacheCon Europe: http://apachecon.com
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.5 will keep your server alive. Download Wicket now!
http://wicketframework.org

Re: VOTE accept fix to WICKET-432 into 1.2.x

Posted by Martijn Dashorst <ma...@gmail.com>.
How does this affect people that have overridden Page.onAttach() but
don't call super()?

Martijn

Re: VOTE accept fix to WICKET-432 into 1.2.x

Posted by Gwyn Evans <gw...@gmail.com>.
+1
/Gwyn

On 31/03/07, Igor Vaynberg <ig...@gmail.com> wrote:
> the subject says it all.
>
> i kinda jumped the gun on this one and committed already by mistake :( my
> appologies.
>
> if the vote doesnt pass i will revert it.
>
> -igor
>


-- 
Download Wicket 1.2.5 now! - http://wicketframework.org

Re: VOTE accept fix to WICKET-432 into 1.2.x

Posted by Eelco Hillenius <ee...@gmail.com>.
+1

Eelco

On 3/30/07, Igor Vaynberg <ig...@gmail.com> wrote:
> the subject says it all.
>
> i kinda jumped the gun on this one and committed already by mistake :( my
> appologies.
>
> if the vote doesnt pass i will revert it.
>
> -igor
>

Re: VOTE accept fix to WICKET-432 into 1.2.x

Posted by Igor Vaynberg <ig...@gmail.com>.
+1

-igor


On 3/30/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> the subject says it all.
>
> i kinda jumped the gun on this one and committed already by mistake :( my
> appologies.
>
> if the vote doesnt pass i will revert it.
>
> -igor
>
>