You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by reudismam <gi...@git.apache.org> on 2018/02/16 13:12:07 UTC
[GitHub] ant pull request #62: Use char notation to represent a character to improve ...
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/62
Use char notation to represent a character to improve performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reudismam/ant character
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 4df60d6b21f4c85df039037531aa1627fc40b68d
Author: reudismam <re...@...>
Date: 2018-02-16T12:49:15Z
Use char notation to represent a character to improve performance.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/62
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/43/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/62
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/37/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/62
this is ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/62
Hi @reudismam, Is there some reference documentation which states that this construct performs better? My brief check of the JLS just showed a note which states that some implementations _might_ perform better with this construct, but other than that I haven't found anything, so just curious.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/62
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by reudismam <gi...@git.apache.org>.
Github user reudismam commented on the issue:
https://github.com/apache/ant/pull/62
Actually, I do not have a documentation, but there are discussions in programming community about the benefits of this change, such as this:
[https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x)
This edit is known to have improved performance on other projects such as Guava Project where they improve performance from 10-25%.
[https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://github.com/google/guava/commit/8f48177132547cee2943c93837d76b898154d722)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Posted by janmaterne <gi...@git.apache.org>.
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/62
These changes might improve performance, but do you have a testsuite with validates that? Most of the changes are done on places which are rarely invoked in a build (without having tested that ;-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org