[GitHub] [tvm] jverma-quic commented on a diff in pull request #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d

[GitBox <gi...@apache.org>]

jverma-quic commented on code in PR #12559:
URL: https://github.com/apache/tvm/pull/12559#discussion_r965462006


##########
tests/python/contrib/test_hexagon/topi/test_resize2d.py:
##########
@@ -26,26 +26,46 @@
 
 @tvm.testing.fixture
 def expected_output_np(
-    input_np, in_height, in_width, out_height, out_width, layout, method, coord_trans
+    input_np,
+    in_height,
+    in_width,
+    out_height,
+    out_width,
+    layout,
+    method,
+    coord_trans,
+    dtype,
 ):
     scale_h = out_height / in_height
     scale_w = out_width / in_width
+
     return resize2d_python(input_np, (scale_h, scale_w), layout, method, coord_trans)
 
 
 @tvm.testing.fixture
 def input_np(input_shape, dtype):
-    return np.random.random(input_shape).astype(dtype)
+    if dtype == "float16":
+        return np.random.random(input_shape).astype(dtype)
+    elif dtype == "uint8":

Review Comment:
   unnecessary 'elif' after 'return'. elif-> if 
   same issue at a few other places where else appears after 'return'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org