You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/11/16 12:07:40 UTC

[PR] [orc] Optimize ORC timestamp type read [incubator-paimon]

JingsongLi opened a new pull request, #2333:
URL: https://github.com/apache/incubator-paimon/pull/2333

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   10X performance improvement.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [orc] Optimize ORC timestamp type read [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2333:
URL: https://github.com/apache/incubator-paimon/pull/2333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [orc] Optimize ORC timestamp type read [incubator-paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2333:
URL: https://github.com/apache/incubator-paimon/pull/2333#issuecomment-1815701508

   test pass for:
       @Test
       public void testTimestamp() {
           long millis = System.currentTimeMillis();
           int nano = 100;
           Timestamp timestamp = new Timestamp(millis);
           timestamp.setNanos(nano + timestamp.getNanos());
           org.apache.paimon.data.Timestamp t1 = org.apache.paimon.data.Timestamp.fromSQLTimestamp(timestamp);
           org.apache.paimon.data.Timestamp t2 = DateTimeUtils.toInternal(millis, nano);
           assertThat(t1).isEqualTo(t2);
       }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [orc] Optimize ORC timestamp type read [incubator-paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2333:
URL: https://github.com/apache/incubator-paimon/pull/2333#issuecomment-1815700346

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org