You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/02/19 16:59:43 UTC
svn commit: r1783673 -
/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
Author: pmouawad
Date: Sun Feb 19 16:59:43 2017
New Revision: 1783673
URL: http://svn.apache.org/viewvc?rev=1783673&view=rev
Log:
Fix leak
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java?rev=1783673&r1=1783672&r2=1783673&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java Sun Feb 19 16:59:43 2017
@@ -105,16 +105,16 @@ public class HeaderManager extends Confi
file = new File(System.getProperty("user.dir")// $NON-NLS-1$
+ File.separator + headFile);
}
- PrintWriter writer = new PrintWriter(new FileWriter(file)); // TODO Charset ?
- writer.println("# JMeter generated Header file");// $NON-NLS-1$
- final CollectionProperty hdrs = getHeaders();
- for (int i = 0; i < hdrs.size(); i++) {
- final JMeterProperty hdr = hdrs.get(i);
- Header head = (Header) hdr.getObjectValue();
- writer.println(head.toString());
+ try ( FileWriter fw = new FileWriter(file);
+ PrintWriter writer = new PrintWriter(fw);) { // TODO Charset ?
+ writer.println("# JMeter generated Header file");// $NON-NLS-1$
+ final CollectionProperty hdrs = getHeaders();
+ for (int i = 0; i < hdrs.size(); i++) {
+ final JMeterProperty hdr = hdrs.get(i);
+ Header head = (Header) hdr.getObjectValue();
+ writer.println(head.toString());
+ }
}
- writer.flush();
- writer.close();
}
/**