You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2005/04/08 00:05:43 UTC
[jira] Created: (MNG-269) DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
-----------------------------------------------------------------------------------------------------------------
Key: MNG-269
URL: http://jira.codehaus.org/browse/MNG-269
Project: m2
Type: Bug
Components: maven-core
Environment: all
Reporter: John Casey
Assigned to: John Casey
Fix For: 1.0-alpha-2
>From the email I sent to the m2-dev list detailing this problem:
I just uncovered a problem which is surely present in the current binary bundles of m2. It has to do with projects that depend on poms which utilize interpolation or managed dependencies...
When such a project exists, the first plugin that resolves dependencies will retrieve the correct and complete POM for each dependency, with interpolation and managed deps included. HOWEVER, this first resolution process will result in the models being incorrectly cached in the project builder (cached before they are interpolated or have defaults injected), which means that each subsequent plugin that uses a cached model which utilizes these features will get a "raw" version of the model; that is, with none of these higher-level features included.
As an interim solution, I have disabled cached-model retrieval from the MavenMetadataSource. While this may slow m2 down a bit (since it will have to build the models every time), it will at least provide correct results until we have the time to address this error properly.
ALSO: this is well documented in the code itself (MavenMetadataSource, DefaultMavenProjectBuilder).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-269) DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-269?page=history ]
Brett Porter updated MNG-269:
-----------------------------
Fix Version: (was: 1.0-alpha-2)
1.0-alpha-1
Assign To: Brett Porter (was: John Casey)
> DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
> -----------------------------------------------------------------------------------------------------------------
>
> Key: MNG-269
> URL: http://jira.codehaus.org/browse/MNG-269
> Project: m2
> Type: Bug
> Components: maven-core
> Environment: all
> Reporter: John Casey
> Assignee: Brett Porter
> Fix For: 1.0-alpha-1
>
> Original Estimate: 4 hours
> Remaining: 4 hours
>
> From the email I sent to the m2-dev list detailing this problem:
> I just uncovered a problem which is surely present in the current binary bundles of m2. It has to do with projects that depend on poms which utilize interpolation or managed dependencies...
> When such a project exists, the first plugin that resolves dependencies will retrieve the correct and complete POM for each dependency, with interpolation and managed deps included. HOWEVER, this first resolution process will result in the models being incorrectly cached in the project builder (cached before they are interpolated or have defaults injected), which means that each subsequent plugin that uses a cached model which utilizes these features will get a "raw" version of the model; that is, with none of these higher-level features included.
> As an interim solution, I have disabled cached-model retrieval from the MavenMetadataSource. While this may slow m2 down a bit (since it will have to build the models every time), it will at least provide correct results until we have the time to address this error properly.
> ALSO: this is well documented in the code itself (MavenMetadataSource, DefaultMavenProjectBuilder).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-269) DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-269?page=comments#action_31712 ]
Brett Porter commented on MNG-269:
----------------------------------
this was fixed through a bit of refactoring - will discuss on m2-dev
> DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
> -----------------------------------------------------------------------------------------------------------------
>
> Key: MNG-269
> URL: http://jira.codehaus.org/browse/MNG-269
> Project: m2
> Type: Bug
> Components: maven-core
> Environment: all
> Reporter: John Casey
> Assignee: Brett Porter
> Fix For: 1.0-alpha-1
>
> Original Estimate: 4 hours
> Remaining: 4 hours
>
> From the email I sent to the m2-dev list detailing this problem:
> I just uncovered a problem which is surely present in the current binary bundles of m2. It has to do with projects that depend on poms which utilize interpolation or managed dependencies...
> When such a project exists, the first plugin that resolves dependencies will retrieve the correct and complete POM for each dependency, with interpolation and managed deps included. HOWEVER, this first resolution process will result in the models being incorrectly cached in the project builder (cached before they are interpolated or have defaults injected), which means that each subsequent plugin that uses a cached model which utilizes these features will get a "raw" version of the model; that is, with none of these higher-level features included.
> As an interim solution, I have disabled cached-model retrieval from the MavenMetadataSource. While this may slow m2 down a bit (since it will have to build the models every time), it will at least provide correct results until we have the time to address this error properly.
> ALSO: this is well documented in the code itself (MavenMetadataSource, DefaultMavenProjectBuilder).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-269) DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-269?page=history ]
Brett Porter closed MNG-269:
----------------------------
Resolution: Fixed
> DefaultMavenProjectBuilder caches wrong version of Models, prior to interpolation or managed dependency injection
> -----------------------------------------------------------------------------------------------------------------
>
> Key: MNG-269
> URL: http://jira.codehaus.org/browse/MNG-269
> Project: m2
> Type: Bug
> Components: maven-core
> Environment: all
> Reporter: John Casey
> Assignee: Brett Porter
> Fix For: 1.0-alpha-1
>
> Original Estimate: 4 hours
> Remaining: 4 hours
>
> From the email I sent to the m2-dev list detailing this problem:
> I just uncovered a problem which is surely present in the current binary bundles of m2. It has to do with projects that depend on poms which utilize interpolation or managed dependencies...
> When such a project exists, the first plugin that resolves dependencies will retrieve the correct and complete POM for each dependency, with interpolation and managed deps included. HOWEVER, this first resolution process will result in the models being incorrectly cached in the project builder (cached before they are interpolated or have defaults injected), which means that each subsequent plugin that uses a cached model which utilizes these features will get a "raw" version of the model; that is, with none of these higher-level features included.
> As an interim solution, I have disabled cached-model retrieval from the MavenMetadataSource. While this may slow m2 down a bit (since it will have to build the models every time), it will at least provide correct results until we have the time to address this error properly.
> ALSO: this is well documented in the code itself (MavenMetadataSource, DefaultMavenProjectBuilder).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org