You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2009/07/21 08:45:24 UTC
svn commit: r796162 -
/tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
Author: markt
Date: Tue Jul 21 06:45:24 2009
New Revision: 796162
URL: http://svn.apache.org/viewvc?rev=796162&view=rev
Log:
Mac compiler doesn't like @Override on methods implementing an interface.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java?rev=796162&r1=796161&r2=796162&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java Tue Jul 21 06:45:24 2009
@@ -44,7 +44,7 @@
public static enum AsyncState {
NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING
- };
+ }
protected static Log log = LogFactory.getLog(AsyncContextImpl.class);
@@ -63,25 +63,21 @@
this.request = request;
}
- @Override
public void complete() {
// TODO SERVLET3 - async
doInternalComplete(false);
}
- @Override
public void dispatch() {
HttpServletRequest sr = (HttpServletRequest)getServletRequest();
String path = sr.getRequestURI();
dispatch(path);
}
- @Override
public void dispatch(String path) {
dispatch(request.getServletContext(),path);
}
- @Override
public void dispatch(ServletContext context, String path) {
// TODO SERVLET3 - async
if (this.state.compareAndSet(AsyncState.STARTED, AsyncState.DISPATCHING)) {
@@ -115,17 +111,14 @@
}
}
- @Override
public ServletRequest getRequest() {
return getServletRequest();
}
- @Override
public ServletResponse getResponse() {
return getServletResponse();
}
- @Override
public void start(Runnable run) {
// TODO SERVLET3 - async
this.dispatch = run;
@@ -186,7 +179,6 @@
this.servletResponse = servletResponse;
}
- @Override
public boolean hasOriginalRequestAndResponse() {
return hasOriginalRequestAndResponse;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
Posted by Mark Thomas <ma...@apache.org>.
Filip Hanik - Dev Lists wrote:
> huh? I thought in Java 6 this should work everywhere
> it sure does for me
Java 6 on my Mac was complaining. I'll double check my Eclipse settings - check
that another JVM isn't creeping in somewhere.
I'd need to double check when I get home but I think this was only an issue with
my Mac and not my PC.
Mark
>
>
>
> On 07/21/2009 12:45 AM, markt@apache.org wrote:
>> Author: markt
>> Date: Tue Jul 21 06:45:24 2009
>> New Revision: 796162
>>
>> URL: http://svn.apache.org/viewvc?rev=796162&view=rev
>> Log:
>> Mac compiler doesn't like @Override on methods implementing an interface.
>>
>> Modified:
>>
>> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java?rev=796162&r1=796161&r2=796162&view=diff
>>
>> ==============================================================================
>>
>> ---
>> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>> (original)
>> +++
>> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>> Tue Jul 21 06:45:24 2009
>> @@ -44,7 +44,7 @@
>>
>> public static enum AsyncState {
>> NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING
>> - };
>> + }
>>
>> protected static Log log =
>> LogFactory.getLog(AsyncContextImpl.class);
>>
>> @@ -63,25 +63,21 @@
>> this.request = request;
>> }
>>
>> - @Override
>> public void complete() {
>> // TODO SERVLET3 - async
>> doInternalComplete(false);
>> }
>>
>> - @Override
>> public void dispatch() {
>> HttpServletRequest sr =
>> (HttpServletRequest)getServletRequest();
>> String path = sr.getRequestURI();
>> dispatch(path);
>> }
>>
>> - @Override
>> public void dispatch(String path) {
>> dispatch(request.getServletContext(),path);
>> }
>>
>> - @Override
>> public void dispatch(ServletContext context, String path) {
>> // TODO SERVLET3 - async
>> if (this.state.compareAndSet(AsyncState.STARTED,
>> AsyncState.DISPATCHING)) {
>> @@ -115,17 +111,14 @@
>> }
>> }
>>
>> - @Override
>> public ServletRequest getRequest() {
>> return getServletRequest();
>> }
>>
>> - @Override
>> public ServletResponse getResponse() {
>> return getServletResponse();
>> }
>>
>> - @Override
>> public void start(Runnable run) {
>> // TODO SERVLET3 - async
>> this.dispatch = run;
>> @@ -186,7 +179,6 @@
>> this.servletResponse = servletResponse;
>> }
>>
>> - @Override
>> public boolean hasOriginalRequestAndResponse() {
>> return hasOriginalRequestAndResponse;
>> }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
huh? I thought in Java 6 this should work everywhere
it sure does for me
On 07/21/2009 12:45 AM, markt@apache.org wrote:
> Author: markt
> Date: Tue Jul 21 06:45:24 2009
> New Revision: 796162
>
> URL: http://svn.apache.org/viewvc?rev=796162&view=rev
> Log:
> Mac compiler doesn't like @Override on methods implementing an interface.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java?rev=796162&r1=796161&r2=796162&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java Tue Jul 21 06:45:24 2009
> @@ -44,7 +44,7 @@
>
> public static enum AsyncState {
> NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING
> - };
> + }
>
> protected static Log log = LogFactory.getLog(AsyncContextImpl.class);
>
> @@ -63,25 +63,21 @@
> this.request = request;
> }
>
> - @Override
> public void complete() {
> // TODO SERVLET3 - async
> doInternalComplete(false);
> }
>
> - @Override
> public void dispatch() {
> HttpServletRequest sr = (HttpServletRequest)getServletRequest();
> String path = sr.getRequestURI();
> dispatch(path);
> }
>
> - @Override
> public void dispatch(String path) {
> dispatch(request.getServletContext(),path);
> }
>
> - @Override
> public void dispatch(ServletContext context, String path) {
> // TODO SERVLET3 - async
> if (this.state.compareAndSet(AsyncState.STARTED, AsyncState.DISPATCHING)) {
> @@ -115,17 +111,14 @@
> }
> }
>
> - @Override
> public ServletRequest getRequest() {
> return getServletRequest();
> }
>
> - @Override
> public ServletResponse getResponse() {
> return getServletResponse();
> }
>
> - @Override
> public void start(Runnable run) {
> // TODO SERVLET3 - async
> this.dispatch = run;
> @@ -186,7 +179,6 @@
> this.servletResponse = servletResponse;
> }
>
> - @Override
> public boolean hasOriginalRequestAndResponse() {
> return hasOriginalRequestAndResponse;
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2009/7/21 <ma...@apache.org>:
> Author: markt
> Date: Tue Jul 21 06:45:24 2009
> New Revision: 796162
>
> URL: http://svn.apache.org/viewvc?rev=796162&view=rev
> Log:
> Mac compiler doesn't like @Override on methods implementing an interface.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java
>
If you are wondering,
this @Override on "methods implementing an interface" is a
(not so well known) difference between Java 5 and Java 6.
http://blogs.sun.com/ahe/entry/override
http://blogs.sun.com/ahe/entry/override_snafu
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org