You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/28 01:11:56 UTC

[GitHub] asifdxtreme closed pull request #232: SCB-127 Optimize log print.

asifdxtreme closed pull request #232: SCB-127 Optimize log print.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/232
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/service/service_dependency.go b/server/service/service_dependency.go
index 4dd8c77..1b36afa 100644
--- a/server/service/service_dependency.go
+++ b/server/service/service_dependency.go
@@ -18,6 +18,7 @@ package service
 
 import (
 	"encoding/json"
+	"fmt"
 	"github.com/apache/incubator-servicecomb-service-center/pkg/util"
 	"github.com/apache/incubator-servicecomb-service-center/pkg/uuid"
 	apt "github.com/apache/incubator-servicecomb-service-center/server/core"
@@ -76,7 +77,7 @@ func (s *MicroServiceService) AddOrUpdateDependencies(ctx context.Context, depen
 		if len(consumerId) == 0 {
 			util.Logger().Errorf(nil, "put request into dependency queue failed, override: %t, consumer %s does not exist.",
 				override, consumerFlag)
-			return pb.CreateResponse(scerr.ErrServiceNotExists, "Get consumer's serviceId is empty."), nil
+			return pb.CreateResponse(scerr.ErrServiceNotExists, fmt.Sprintf("Consumer %s does not exist.", consumerFlag)), nil
 		}
 
 		dependencyInfo.Override = override


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services