You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/04 20:35:41 UTC

[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19796: [v1.x] ONNX export support for multiple input data types

josephevans commented on a change in pull request #19796:
URL: https://github.com/apache/incubator-mxnet/pull/19796#discussion_r570525200



##########
File path: python/mxnet/contrib/onnx/mx2onnx/export_model.py
##########
@@ -28,7 +28,7 @@
 from ._export_helper import load_module
 
 
-def export_model(sym, params, input_shape, input_type=np.float32,

Review comment:
       Instead of changing input_type to a required parameter (and requiring scripts that use this function to be changed), could we check if input_type is a string/dtype value and convert that to a single-item list (for when there's only 1 input)? This would preserve existing behavior, but also allow for passing in a list of input dtypes. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org