You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Roman Coedo <no...@github.com> on 2014/06/27 13:02:51 UTC

[jclouds-labs-aws] JCLOUDS-457: Multiple fixes (#28)

This commit addresses some problems found in the code:

- Now VaultMetadata returns a copy of the creation date instead
of their own instance.

- Added a checkNotNull for PaginatedVaultCollection iterable.

- Added a test for listVaults with an empty list of vaults.
You can merge this Pull Request by running:

  git pull https://github.com/rcoedo/jclouds-labs-aws fixes

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-aws/pull/28

-- Commit Summary --

  * JCLOUDS-457: Multiple fixes

-- File Changes --

    M glacier/src/main/java/org/jclouds/glacier/domain/PaginatedVaultCollection.java (4)
    M glacier/src/main/java/org/jclouds/glacier/domain/VaultMetadata.java (4)
    M glacier/src/test/java/org/jclouds/glacier/GlacierClientMockTest.java (11)
    A glacier/src/test/resources/json/listVaultsWithEmptyListResponseBody.json (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-aws/pull/28.patch
https://github.com/jclouds/jclouds-labs-aws/pull/28.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/28

Re: [jclouds-labs-aws] JCLOUDS-457: Multiple fixes (#28)

Posted by Andrew Gaul <no...@github.com>.

Pushed to master as 9113ce56249fb505d81153b09d4f2c5e83b7660d.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/28#issuecomment-47408469

Re: [jclouds-labs-aws] JCLOUDS-457: Multiple fixes (#28)

Posted by Andrew Gaul <no...@github.com>.

Closed #28.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/28#event-136111565

Re: [jclouds-labs-aws] JCLOUDS-457: Multiple fixes (#28)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-aws-pull-requests #59](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/59/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/28#issuecomment-47331898

Re: [jclouds-labs-aws] JCLOUDS-457: Multiple fixes (#28)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-aws #1046](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1046/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/28#issuecomment-47332114