You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/03/14 22:51:24 UTC

[Impala-ASF-CR] IMPALA-8277: support ranges in CPU lists

Hello Michael Ho, Lars Volker, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12755

to look at the new patch set (#4).

Change subject: IMPALA-8277: support ranges in CPU lists
......................................................................

IMPALA-8277: support ranges in CPU lists

Generalise the logic to handle comma-separated ranges.

Testing:
Added unit test for parsing logic to test the various possible
permutations of CPU ranges.

Porting notes:
This is a port of KUDU-2721. There were some minor conflicts
around include ordering in sysinfo.cc that I resolved by
switching more of includes to match Kudu's version. I also
made sure to make sysinfo-test runnable without modifications
to the source file, which is possible with the new unified
backend test infrastructure.

Change-Id: I97311bfbcf70bea069e941b6e7f4f015fb781b3f
Reviewed-on: http://gerrit.cloudera.org:8080/12657
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M be/CMakeLists.txt
M be/src/gutil/CMakeLists.txt
A be/src/gutil/sysinfo-test.cc
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
5 files changed, 157 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/12755/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97311bfbcf70bea069e941b6e7f4f015fb781b3f
Gerrit-Change-Number: 12755
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>