You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/04 12:54:32 UTC
Re: Review Request 69954: Added a SLRP unit test for persistent block
volume creation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69954/#review213397
-----------------------------------------------------------
Could you rebase this patch?
- Benjamin Bannier
On Feb. 12, 2019, 6:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69954/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:27 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test `CreateDestroyPersistentBlockVolume` verifies that SLRP would fail
> a `CREATE` operation on a BLOCK disk resource, and a followup `DESTROY`
> will be dropped (instead of failing the SLRP).
>
>
> Diffs
> -----
>
> src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69954/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>