You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/06/26 05:50:13 UTC
[GitHub] zeppelin pull request #1088: [ZEPPELIN-1062] Get original InterpreterSetting...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1088
[ZEPPELIN-1062] Get original InterpreterSetting when there is no change
### What is this PR for?
When we update interpreter property values, we edit some values and click "save" button. Then a bootstrap dialog is show up. In this step, if we click "cancel", the updated value is still existed in the table. This new value is not stored actually. After refresh, the original value will be shown.
I just get original InterpreterSetting(`getInterpreterSettings()`) when there is no change(`result`) for fixing this bug.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
[ZEPPELIN-1062](https://issues.apache.org/jira/browse/ZEPPELIN-1062)
### How should this be tested?
It's really simple. Just see the below attached screenshots.
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-1062
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1088
----
commit ee0d0d8061729f316e2b5873a81bd4b5bc55fbf5
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-25T20:23:58Z
Get original InterpreterSetting when there is no change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1088: [ZEPPELIN-1062] Get original InterpreterSetting...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1088
@prabhjyotsingh Sorry for my late response. You're right. After just clicking `cancel`, it should focus on textbox again as you said. And regarding your second comment, I blocked ESC back drop & `x` closing. Could you check this again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1088
Thank you for taking care of it. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1088
Also what happens when user clicks on close ("x") button, instead of "OK" or "Close" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1088
IMO, when user clicks on cancel after clicking on save; user should see the edit view back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---