You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/05/03 01:19:53 UTC
Re: Review Request: OOZIE-818: CoordChangeXCommand deletes past coordinator
actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7490
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16585>
remove trailing tab/spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16586>
we should not delete actions if it is already running, that one should stay. while extremely unlikely, we should do that check
- Alejandro
On 2012-04-23 08:07:07, shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4842/
> -----------------------------------------------------------
>
> (Updated 2012-04-23 08:07:07)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
>
>
> This addresses bug OOZIE-818.
> https://issues.apache.org/jira/browse/OOZIE-818
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
>
> Diff: https://reviews.apache.org/r/4842/diff
>
>
> Testing
> -------
>
> UT - TestCoordChangeXCommand
>
>
> Thanks,
>
> shwethags
>
>