[GitHub] [hudi] todd5167 commented on a change in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

[GitBox <gi...@apache.org>]

todd5167 commented on a change in pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r840994988



##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveSyncMode.java
##########
@@ -26,6 +26,10 @@
    * The HMS mode use the hive meta client to sync metadata.
    */
   HMS,
+  /**
+   * The GLUE mode use the glue client to sync metadata.
+   */
+  GLUE,

Review comment:
       > Not sure if `GLUE` belongs to kind of sync mode ? Even though GLUE uses supports hive protocol, we may need to think how to re-organize these syncing params.
   
   
   The glue client depends on hiveconf, and the parameters currently used in my test are configured as follows:
   
     'hive_sync.enable' = 'true',
     'hive_sync.mode' = 'glue',
     'hive_sync.table' = 'test_hudi_glue',
     'hive_sync.skip_ro_suffix' = 'true',
     'hive_sync.db' = 'hudi_meta_glue'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org